New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 868447 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

GetLatestInFlightSurface should not return null if fallback doesn't exist

Project Member Reported by akaba@google.com, Jul 27

Issue description

SurfaceManager::GetLatestInFlightSurface use the primary to do something useful instead of returning null when fallback doesn't exist or have no activeframes.
 
Components: Internals>Compositing
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ff3de3fed70b8fbf9b2cf18d897e01514d2d7ae

commit 2ff3de3fed70b8fbf9b2cf18d897e01514d2d7ae
Author: akaba <akaba@google.com>
Date: Tue Jul 31 16:24:24 2018

GetLatestInFlightSurface should not return null if fallback doesn't exist

GetLatestInFlightSurface will return null if fallback surface doesn't
exists which might happen after garbage collection, hence causing
jittering when resizing.
This CL refactor SurfaceManager::GetLatestInFlightSurface to return a
surface in the case when fallback is non-existent.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ib95b4ca3f8819b668022fd9b6942304b07cef340
Bug:  868447 
Reviewed-on: https://chromium-review.googlesource.com/1153088
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Andre Kaba <akaba@google.com>
Cr-Commit-Position: refs/heads/master@{#579427}
[modify] https://crrev.com/2ff3de3fed70b8fbf9b2cf18d897e01514d2d7ae/components/viz/service/display/surface_aggregator.cc
[modify] https://crrev.com/2ff3de3fed70b8fbf9b2cf18d897e01514d2d7ae/components/viz/service/frame_sinks/surface_synchronization_unittest.cc
[modify] https://crrev.com/2ff3de3fed70b8fbf9b2cf18d897e01514d2d7ae/components/viz/service/surfaces/surface.cc
[modify] https://crrev.com/2ff3de3fed70b8fbf9b2cf18d897e01514d2d7ae/components/viz/service/surfaces/surface_manager.cc
[modify] https://crrev.com/2ff3de3fed70b8fbf9b2cf18d897e01514d2d7ae/components/viz/service/surfaces/surface_manager.h

Status: Fixed (was: Assigned)

Sign in to add a comment