New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 868442 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 862514



Sign in to add a comment

[MdRefresh] Regression: White space above the Omnibox is 1px vertically larger now

Project Member Reported by meh...@chromium.org, Jul 27

Issue description

Chrome Version: Canary 70.0.3504.0 
OS: macOS, but probably OS=All

What steps will reproduce the problem?
(1) Open a NTP
(2) Unfocus the Omnibox, so that the blue focus ring disappears
(3) Compare the white space above and below the Omnibox

What is the expected result?
4px on top and bottom


What happens instead?
5px on top and 4px on botton.

This seems to be a recent regression. (Not sure if this change is intended.)
 
Bildschirmfoto 2018-07-27 um 19.28.27.png
28.0 KB View Download
Labels: -Type-Bug Type-Bug-Regression
Looks like the Buttons are also no longer aligned with the Omnibox.
Not_zoomed.png
17.0 KB View Download
Zoomed.png
21.0 KB View Download
Blocking: 862514
Components: -UI>Browser>TabStrip UI>Browser>Toolbar
Labels: -Needs-Bisect Proj-MdRefresh
Owner: pbos@chromium.org
Status: Assigned (was: Untriaged)
Got it: https://chromium.googlesource.com/chromium/src/+log/17cb8dcddcc0dbbbd2d3d1022f3f5f5d15f0f800..16fdc860429d8180170ede793bfbda6503a908f1

Probably caused by https://chromium.googlesource.com/chromium/src/+/fc6a591e5c36e920725061d60f71bc5e3005d0fe

pbos@: Can you please take a look?

Thanks :)
Mehmet
Status: Started (was: Assigned)
Good find, I think this is due to the Windows font I'm testing with having the same size ("or size_delta" in the code) for 17 and 18 available pixels, so even though I tried getting a font for 18 pixels tall I only got one that filled 17, so 18px looked OK on my end but there might be a 1px taller font on your end.

I think the fix is simply to decrease this 18px value to 17 which is probably the actual available space. Touchable's current value should be safe as this size_delta value was unique. available_px -> size_delta values for my system below

C:\src\chromium\src (fix_hindi)>autoninja -C out\Default chrome && out\Default\chrome.exe
ninja.exe -C out\Default chrome -j 160 -l 8
ninja: Entering directory `out\Default'
[1 processes, 3/3 @ 0.1/s : 30.160s ] LINK(DLL) chrome.dll chrome.dll.lib chrome.dll.pdb
24 -> 4
23 -> 3
22 -> 2
21 -> 1
20 -> 1
19 -> 0
18 -> 0
17 -> 0
16 -> -1
15 -> -2
[3916:7344:0727/114145.107:ERROR:account_tracker.cc(253)] OnGetTokenFailure: Invalid credentials (2).

C:\src\chromium\src (fix_hindi)>autoninja -C out\Default chrome && out\Default\chrome.exe --lang=hi
ninja.exe -C out\Default chrome -j 160 -l 8
ninja: Entering directory `out\Default'
ninja: no work to do.
24 -> 1
23 -> 0
22 -> -1
21 -> -2
20 -> -2
19 -> -3
18 -> -3
17 -> -3
16 -> -4
15 -> -5
Thanks for looking into it. Yes, on my end on my old MacBook Air (Non-Retina) from 2012 it is broken. Unfortunately (because I have no other) I can‘t tell you how it is looking on a modern MacBook with Retina Display. But probably the same as on my device. 
I've a fix up for it that reduces the reported available height from 18 to 17, I'd love if you can help verify it in the next Canary release after that lands and bugdroid updates this bug.
Thanks! Of course, as soon as it lands, I‘ll verify it in one of the following Chromium Snapshots. 
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cdb7dd4de9d13ce3b5f74e39d47f96bd2383a26

commit 0cdb7dd4de9d13ce3b5f74e39d47f96bd2383a26
Author: Peter Boström <pbos@chromium.org>
Date: Sun Jul 29 06:28:15 2018

Decrease available ToolbarButton height for font

The current 18dp fixed height results in pushing the total button height
on Mac. This doesn't happen by default on Windows as the default font
results in equal size_delta values for 18dp and 17dp available height.

This probably means that 17dp is the actual available height that
doesn't increase the toolbar-button height.

Bug:  chromium:862514 ,  chromium:868442 
Change-Id: I7c07eb987cb5e4f7a0f200dcbe77b2ac72a751f3
Reviewed-on: https://chromium-review.googlesource.com/1153574
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578947}
[modify] https://crrev.com/0cdb7dd4de9d13ce3b5f74e39d47f96bd2383a26/chrome/browser/ui/views/harmony/chrome_typography.cc

Hey pbos@,

I checked latest Chromium Snapshot #578947 which includes your CL and the issue is fixed for me in macOS on my MacBook Air :)

- The white space is 4px above and below the Omnibox again.
- The Omnibox and Extension Icons are aligned again.

Please find enclosed two screenshots.

Unfortunately I can't verify the fix on a device with a Retina Display, because I don't have one :(

Thank you very much again for the quick fix.
Not_Zoomed.png
30.1 KB View Download
Zoomed.png
55.5 KB View Download
Labels: TE-Verified-70.0.3507.0 TE-Verified-M70
Verified the fix on Mac(Retina) 10.13.1 using Chrome version #70.0.3507.0 as per the comment #0.
Attaching screen shot for reference.
Observed the white space above and below the omnibox is same.
Hence, the fix is working as expected. 
Adding the verified labels.
Note: Able to reproduce the issue on chrome version 70.0.3504.0 and same spacing is seen on Win/Linux before and after fix.

Thanks...!!



868442 CL Verification.png
123 KB View Download
Status: Verified (was: Started)
Thanks! I'll use the blocked bug to request the merges.
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 30

Labels: merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4961c5b9c0c61e3ffbc65c6ef87d897ea0f28c5

commit e4961c5b9c0c61e3ffbc65c6ef87d897ea0f28c5
Author: Peter Boström <pbos@chromium.org>
Date: Mon Jul 30 23:24:01 2018

Decrease available ToolbarButton height for font

The current 18dp fixed height results in pushing the total button height
on Mac. This doesn't happen by default on Windows as the default font
results in equal size_delta values for 18dp and 17dp available height.

This probably means that 17dp is the actual available height that
doesn't increase the toolbar-button height.

Bug:  chromium:862514 ,  chromium:868442 
Change-Id: I7c07eb987cb5e4f7a0f200dcbe77b2ac72a751f3
Reviewed-on: https://chromium-review.googlesource.com/1153574
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#578947}(cherry picked from commit 0cdb7dd4de9d13ce3b5f74e39d47f96bd2383a26)
Reviewed-on: https://chromium-review.googlesource.com/1155617
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#254}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/e4961c5b9c0c61e3ffbc65c6ef87d897ea0f28c5/chrome/browser/ui/views/harmony/chrome_typography.cc

Labels: TE-Verified-69.0.3497.23 TE-Verified-M69
Verified the fix on Mac(Retina) 10.13.1 using Chrome version #69.0.3497.23 as per the comment #0.
Attaching screen shot for reference.
Observed the white space above and below the omnibox is same.
Hence, the fix is working as expected. 
Adding the verified labels.
Note: Able to reproduce the issue on chrome version 70.0.3504.0 and same spacing is seen on Win/Linux before and after fix.

Thanks...!!

868442 - 3497 CL.png
54.2 KB View Download
Cc: abdulsyed@chromium.org
+abdulsyed@ fyi, M69 merges taken for Proj-MdRefresh .

Sign in to add a comment