New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 868432 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 442344



Sign in to add a comment

[New Tab] Look into NTP performance

Project Member Reported by ma...@chromium.org, Jul 27

Issue description

Avoid going to the Favicon Service on as many NTP loads as possible.
 
Summary: [New Tab] Look into NTP performance (was: [New Tab] Look into NTP Icons Caching)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebf2b62921d4392bede4d9a484b0d51203cc5c37

commit ebf2b62921d4392bede4d9a484b0d51203cc5c37
Author: Mathieu Perreault <mathp@chromium.org>
Date: Mon Jul 30 18:07:48 2018

[NTP] Allow for simple caching of NTP Icons

With this change, no caching headers are sent for icons, which is a
default of in-memory caching.

Bug: 868432
Test: None
Change-Id: I8dedb6a33035dd7e6cf32479921c0e6180e9ad03
Reviewed-on: https://chromium-review.googlesource.com/1154362
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579088}
[modify] https://crrev.com/ebf2b62921d4392bede4d9a484b0d51203cc5c37/chrome/browser/search/ntp_icon_source.cc
[modify] https://crrev.com/ebf2b62921d4392bede4d9a484b0d51203cc5c37/chrome/browser/search/ntp_icon_source.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dee1b590e6d34af2702f7ee7e1fe4dc3db2d1197

commit dee1b590e6d34af2702f7ee7e1fe4dc3db2d1197
Author: Mathieu Perreault <mathp@chromium.org>
Date: Tue Jul 31 02:58:35 2018

[NTP] Defer the voice JS file

It will be executed "when the page has finished parsing" which seems right
for this script.

Bug: 868432
Change-Id: Icb0fb03518aca785c7a3d8583bcbfaecd4cb1487
Reviewed-on: https://chromium-review.googlesource.com/1154365
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579295}
[modify] https://crrev.com/dee1b590e6d34af2702f7ee7e1fe4dc3db2d1197/chrome/browser/resources/local_ntp/local_ntp.html

Labels: zine-triaged
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/899c3bff49d6ba128c8eb413117d518dd5a38b0d

commit 899c3bff49d6ba128c8eb413117d518dd5a38b0d
Author: Mathieu Perreault <mathp@chromium.org>
Date: Tue Jul 31 20:32:22 2018

[Local NTP] Add config.js as top-level instead of dynamically added.

To load the NTP faster, we include config.js data in the local ntp
page's initial resources instead of later added by local_ntp.js

To achieve this, we refactor into the SearchConfigProvider and cache
the config data. It will be recomputed on Search provider change.

We also now declare the CSP as part of a <meta> tag instead of headers,
since in URLDataSource the headers are created on the IO thread and
the response on the UI thread. Doing everything in the local_ntp.html
response avoids races nicely.

Bug: 868432
Change-Id: Iab38ca2b2e032a58c2d404938065a612b08cc69a
Reviewed-on: https://chromium-review.googlesource.com/1154687
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579553}
[modify] https://crrev.com/899c3bff49d6ba128c8eb413117d518dd5a38b0d/chrome/browser/resources/local_ntp/local_ntp.html
[modify] https://crrev.com/899c3bff49d6ba128c8eb413117d518dd5a38b0d/chrome/browser/resources/local_ntp/local_ntp.js
[modify] https://crrev.com/899c3bff49d6ba128c8eb413117d518dd5a38b0d/chrome/browser/search/local_ntp_source.cc
[modify] https://crrev.com/899c3bff49d6ba128c8eb413117d518dd5a38b0d/chrome/browser/search/local_ntp_source.h

Blocking: 442344

Sign in to add a comment