New issue
Advanced search Search tips

Issue 868414 link

Starred by 2 users
Status: Fixed
Owner:
mmenke@chromium.org
Closed: Jul 27
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification



Sign in to add a comment

Improve cookie-related NetworkContextConfigurationBrowserTests

Project Member Reported by mmenke@chromium.org, Jul 27 
In particular, there are some incorrect comments about the system/safebrowsing cookie stores.  We should also be checking that cookies are saved to disk and restored on browser restart.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0762f5438d83c59af84b717ae3a6982e54eba37b

commit 0762f5438d83c59af84b717ae3a6982e54eba37b
Author: Matt Menke <mmenke@chromium.org>
Date: Fri Jul 27 18:57:52 2018

Add integration tests for cookie persistance

The tests check that cookies are persisted (Or not) for each of the
NetworkContexts in Chrome.

Also, fix comments in NetworkContextConfigurationBrowserTests. In
particular, the System and SafeBrowsing NetworkContexts do support
cookies, they just don't support some configuration options being
tested.

Bug:  868414 
Change-Id: I8542a1ff7685efcf6588b29dcb5058dd06f1ceeb
Reviewed-on: https://chromium-review.googlesource.com/1153141
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578733}
[modify] https://crrev.com/0762f5438d83c59af84b717ae3a6982e54eba37b/chrome/browser/net/network_context_configuration_browsertest.cc

Comment 2 by mmenke@chromium.org, Jul 27

Status: Fixed (was: Started)
►

Sign in to add a comment