New issue
Advanced search Search tips

Issue 868405 link

Starred by 1 user
Status: Verified
Owner:
rsesek@chromium.org
Closed: Jul 30
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Missing keyboard shortcuts for Edit > Find > {Use Selection for Find, Jump to Selection}

Project Member Reported by rsesek@chromium.org, Jul 27 
Chrome Version: 70.0.3504.0
OS: macOS 10.13.6

What steps will reproduce the problem?
(1) Open the Edit > Find menu from the main menubar
(2) Look at the "Use Selection for Find" and "Jump to Selection" menu items
(3) No keyboard shortcut listed.

What is the expected result?
"Use Selection for Find" = Cmd+E
"Jump to Selection" = Cmd+J

What happens instead?

Likely a regression from my https://chromium.googlesource.com/chromium/src/+/124f80f9c6f0935ed1369617346443d4321427bf


Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71e508b91f4d835d0f6a6bc7a8f1ca61d4d48c7d

commit 71e508b91f4d835d0f6a6bc7a8f1ca61d4d48c7d
Author: Robert Sesek <rsesek@chromium.org>
Date: Fri Jul 27 21:52:16 2018

[Mac] Add two missing key equivalents in Edit>Find.

"Use Selection for Find" = Cmd+E
"Jump to Selection" = Cmd+J

Bug:  868405 
Change-Id: I83a6e7fdecb21b5d9e0aabd2ecb8fc4483d7a273
Reviewed-on: https://chromium-review.googlesource.com/1153142
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578820}
[modify] https://crrev.com/71e508b91f4d835d0f6a6bc7a8f1ca61d4d48c7d/chrome/browser/ui/cocoa/main_menu_builder.mm

Comment 2 by viswa.karala@chromium.org, Jul 30 

Able to reproduce the issue on chrome reported version# 70.0.3504.0 using Mac 10.12.6(Build without fix)
Verified the fix on Mac 10.12.6 on latest chrome version# 70.0.3407.0 as per comment# 0
Attached screenshot for reference and
Observed "Use Selection for Find = Cmd+E and Jump to Selection = Cmd+J"
Hence fix is working as excepted
Adding the verified labels.

Thanks!
868405.png
157 KB View Download

Comment 3 by viswa.karala@chromium.org, Jul 30

Labels: TE-Verified-M70 TE-Verified-70.0.3507.0
Able to reproduce the issue on chrome reported version# 70.0.3504.0 using Mac 10.12.6(Build without fix)
Verified the fix on Mac 10.12.6 on latest chrome version# 70.0.3407.0 as per comment# 0
Attached screenshot for reference and
Observed "Use Selection for Find = Cmd+E and Jump to Selection = Cmd+J"
Hence fix is working as excepted
Adding the verified labels.

Thanks!
868405.png
157 KB View Download

Comment 4 by rsesek@chromium.org, Jul 30

Status: Verified (was: Assigned)
►

Sign in to add a comment