Issue metadata
Sign in to add a comment
|
[MacViews] In Fullscreen Mode, and the Hide the Toolbar option is enabled, Tabstrip/Omnibox/BMB don't appear when you move the mouse to the top of the screen |
||||||||||||||||||||||
Issue descriptionChrome Version: Canary 70.0.3504.0 OS: macOS 10.13.6 What steps will reproduce the problem? (1) Switch into Fullscreen Mode via CTRL-CMD-F (2) Hide the Toolbar in Fullscreen Mode via SHIFT-CMD-F (3) Move the Mouse cursor to the top of the screen What is the expected result? Tabstrip/Omnibox/BMB should appear, so you can navigate easily. What happens instead? Tabstrip/Omnibox/BMB don't appear. Only Menubar and the grey bar with the window controls appear. That was the way it worked before in Cocoa. Thanks Mehmet
,
Sep 5
FYI this behavior has reached the stable build of Chrome on MacOS. It renders navigation impossible in fullscreen mode.
,
Sep 6
Issue 881312 has been merged into this issue.
,
Sep 6
Yeah, this is in stable now, Chrome 69. Very annoying.
,
Sep 6
I'm actively working on bringing this back. For now, a workaround is to use cmd+shift+F to show and hide the toolbar in fullscreen.
,
Sep 7
Issue 881947 has been merged into this issue.
,
Sep 8
@sdy nice! thanks a lot for working on this. two observations: 1. the window buttons appear to overlap the new tab, rather than what appears to be current behavior (attached screenshot) 2. it would be interesting to see if the correct behavior still preserved when the address / tab bar is hidden via: ⌘ + Shift + f
,
Sep 11
Re. #9, yep, that's just a PoC :-). I'm planning to fix both of those things! Let me also merge this into another bug that happened to be opened first.
,
Sep 11
Oh, I just realized that 831219 is serving more as a tracking bug. Un-merged.
,
Sep 13
Kicking this up to Pri-1 based on star count and other reports.
,
Sep 13
Issue 882640 has been merged into this issue.
,
Sep 14
Looks great. Thanks!!!
,
Sep 14
What about SHIFT-CMD-F mode? The issue is mainly about this exact mode. The video demonstrates some improvements in CTRL-CMD-F mode, but that is not related to the issue.
,
Sep 14
,
Sep 14
Issue 884292 has been merged into this issue.
,
Sep 15
Issue 884324 has been merged into this issue.
,
Sep 16
yeah, I'd like to know that the SHIFT-CMD-F mode is being fixed as pressing that whenever I need to change tabs or type in a new website is annoying. the browser is 99% unusable in that mode in this state
,
Sep 16
Issue 884504 has been merged into this issue.
,
Sep 17
Issue 884657 has been merged into this issue.
,
Sep 17
Yes, the change covers both modes even though I've only posted recordings of the toolbar visible mode.
,
Sep 18
,
Sep 19
Issue 886929 has been merged into this issue.
,
Sep 19
Thanks for working on bringing the shift-cmd-F reveal/autohide functionality back. It is a huge inconvenience to have to hit the shortcut every time. When do you think we'll see an update fixing this?
,
Sep 20
,
Sep 27
Issue 889762 has been merged into this issue.
,
Oct 11
,
Oct 12
,
Oct 16
Issue 894088 has been merged into this issue.
,
Oct 19
Issue 896896 has been merged into this issue.
,
Oct 22
,
Oct 25
Issue 899061 has been merged into this issue.
,
Oct 26
Issue 898364 has been merged into this issue.
,
Nov 2
Issue 901347 has been merged into this issue.
,
Nov 15
Issue 905038 has been merged into this issue.
,
Nov 15
,
Nov 15
Issue 905776 has been merged into this issue.
,
Nov 17
Issue 905417 has been merged into this issue.
,
Nov 19
**UI mass Triage** We were unable to reproduce this bug. If this bug still reproduces for you, please reopen or file a new issue. Thanks!
,
Nov 19
,
Nov 19
This is still an issue.
,
Nov 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9bfd10b3bcbc4af6b9a3132937fb4c48401bbe15 commit 9bfd10b3bcbc4af6b9a3132937fb4c48401bbe15 Author: Sidney San Martín <sdy@chromium.org> Date: Mon Nov 19 23:27:44 2018 Mac: Delete the OSX.Fullscreen.ToolbarStyle histogram. This'll make it easier for me to delete surrounding code, and I can't find any references to it so I suspect that it's safe to prune. Bug: 868398 Change-Id: Ib62d77f87df261200c6e6c1b821f99ed707041b9 Reviewed-on: https://chromium-review.googlesource.com/c/1343058 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#609503} [modify] https://crrev.com/9bfd10b3bcbc4af6b9a3132937fb4c48401bbe15/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.h [modify] https://crrev.com/9bfd10b3bcbc4af6b9a3132937fb4c48401bbe15/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.mm [modify] https://crrev.com/9bfd10b3bcbc4af6b9a3132937fb4c48401bbe15/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm [modify] https://crrev.com/9bfd10b3bcbc4af6b9a3132937fb4c48401bbe15/tools/metrics/histograms/histograms.xml
,
Dec 27
Issue 904824 has been merged into this issue.
,
Jan 14
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by robliao@chromium.org
, Jul 31Owner: sdy@chromium.org
Status: Assigned (was: Untriaged)