Issue metadata
Sign in to add a comment
|
FlingControllerTest.EarlyTouchpadFlingCancelationOnInertialGSUAckNotConsumed flakes under Fuchsia/ARM64 FYI bot |
||||||||||||||||||||||
Issue descriptionTest failed in run https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-fyi-arm64-rel/516 for example, with: [ RUN ] FlingControllerTest.EarlyTouchpadFlingCancelationOnInertialGSUAckNotConsumed ../../content/browser/renderer_host/input/fling_controller_unittest.cc:296: Failure Expected: (last_sent_wheel_.delta_x) > (0.f), actual: -2.5894 vs 0 Stack trace: #00: testing::internal::AssertHelper::operator=(testing::Message const&) const at gtest.cc:? #01: content::FlingControllerTest_EarlyTouchpadFlingCancelationOnInertialGSUAckNotConsumed_Test::TestBody() at fling_controller_unittest.cc:? [ FAILED ] FlingControllerTest.EarlyTouchpadFlingCancelationOnInertialGSUAckNotConsumed (235 ms) This test was last modified by https://chromium-review.googlesource.com/c/chromium/src/+/1140912 on July 23rd, which is around the time we first started noticing flakes, so assigning to sahel@ to revert/disable/fix as appropriate.
,
Jul 31
I don't know the reason of the flakes, yet. Will disable it on Fuchsia till I find out what the root cause is.
,
Jul 31
,
Aug 7
De-duping this with issue 836996 to track general flakiness in FlingControllerTest tests.
,
Sep 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d2d28fc023390086300faeb913b591839b899eb commit 2d2d28fc023390086300faeb913b591839b899eb Author: Sahel Sharify <sahel@chromium.org> Date: Fri Sep 21 16:30:11 2018 Fix flaky FlingController unittests on Fuchsia. The fling unittests are using mock clock to make sure that the tests are stable. Bug: 868381 Change-Id: I4bafbb71edd668ea553507c00a8784c994f49597 Reviewed-on: https://chromium-review.googlesource.com/1157291 Reviewed-by: Jonathan Ross <jonross@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#593214} [modify] https://crrev.com/2d2d28fc023390086300faeb913b591839b899eb/content/browser/renderer_host/input/fling_controller.cc [modify] https://crrev.com/2d2d28fc023390086300faeb913b591839b899eb/content/browser/renderer_host/input/fling_controller.h [modify] https://crrev.com/2d2d28fc023390086300faeb913b591839b899eb/content/browser/renderer_host/input/fling_controller_unittest.cc [modify] https://crrev.com/2d2d28fc023390086300faeb913b591839b899eb/content/browser/renderer_host/input/input_router_impl.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by w...@chromium.org
, Jul 30