New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 868376 link

Starred by 1 user
Status: Fixed
Owner:
johnchen@chromium.org
Closed: Jul 31
Cc:
rogerta@chromium.org
█ markusheintz@chromium.org
johnchen@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

ChromeDriverTest.testHasFocusOnStartup in chromedriver_py_tests failing on chromium.mac/Mac10.10 Tests

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jul 27 
Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of smcgruer@google.com

ChromeDriverTest.testHasFocusOnStartup in chromedriver_py_tests failing on chromium.mac/Mac10.10 Tests

Builders failed on: 
- Mac10.10 Tests: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/34009
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/34005
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/34000

Example failure: 

======================================================================
FAIL: testHasFocusOnStartup (__main__.ChromeDriverTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "../../chrome/test/chromedriver/test/run_py_tests.py", line 1100, in testHasFocusOnStartup
    self.assertTrue(self._driver.ExecuteScript('return document.hasFocus()'))
AssertionError: False is not true

Comment 1 by smcgruer@chromium.org, Jul 27

Cc: -smcgruer@google.com
Components: Tests>WebDriver
Owner: kereliuk@chromium.org
Status: Assigned (was: Available)
kereliuk@ - PTAL, test appears to be flaky on Mac10.10.

Comment 2 by johnchen@chromium.org, Jul 30

Owner: johnchen@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/413baa14ff7c9123da4f065a12f19ee692ed3dc6

commit 413baa14ff7c9123da4f065a12f19ee692ed3dc6
Author: Peter Boström <pbos@chromium.org>
Date: Mon Jul 30 23:08:21 2018

Disable ChromeDriverTest.testHasFocusOnStartup

Very flaky on Mac 10.10 Tests.

Bug:  chromium:868376 
Change-Id: I415dd89ba7c666630e2d65950c2c5472d2e11968
Reviewed-on: https://chromium-review.googlesource.com/1155819
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579221}
[modify] https://crrev.com/413baa14ff7c9123da4f065a12f19ee692ed3dc6/chrome/test/chromedriver/test/run_py_tests.py

Comment 4 by pbos@chromium.org, Jul 30

Labels: -Sheriff-Chromium
Removing the sheriff label since the test is disabled on Mac for now.

Comment 5 by johnchen@chromium.org, Jul 31

Cc: rogerta@chromium.org markusheintz@chromium.org johnchen@chromium.org
 Issue 868877  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c08de44384342b4fa5b59d7da57ba7e368e3ae23

commit c08de44384342b4fa5b59d7da57ba7e368e3ae23
Author: John Chen <johnchen@chromium.org>
Date: Tue Jul 31 19:38:59 2018

[ChromeDriver] Delete flaky testHasFocusOnStartup

Delete test case ChromeDriverTest.testHasFocusOnStartup, which is
inherently flaky, as any pop-up window can cause Chrome to lose focus.

Bug:  868376 
Change-Id: Ie9b737791df3eadb85fb9525775963c9a997be7b
Reviewed-on: https://chromium-review.googlesource.com/1157072
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579532}
[modify] https://crrev.com/c08de44384342b4fa5b59d7da57ba7e368e3ae23/chrome/test/chromedriver/test/run_py_tests.py

Comment 7 by johnchen@chromium.org, Jul 31

Status: Fixed (was: Assigned)
Fixed by deleting the flaky test.
►

Sign in to add a comment