New issue
Advanced search Search tips

Issue 868366 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 828317
issue 870223



Sign in to add a comment

Add a Mojo service to connect to FontUniqueNameLookup

Project Member Reported by drott@chromium.org, Jul 27

Issue description

In  issue 867877  we're introducing a font scanner on Android for font unique name lookups. The renderers need to be able to connect to this component, hence introduce a mojo service in render_process_host.


 
Blocking: 870223
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/541bea6d4a914daec8710052b2c640bd05786046

commit 541bea6d4a914daec8710052b2c640bd05786046
Author: Dominik Röttsches <drott@chromium.org>
Date: Thu Aug 02 09:42:07 2018

Add a Mojo IPC service to connect to FontUniqueNameLookup implementation

Add a Mojo service to RenderProcessHost for renderers being able to
connect to the FontUniqueNameLookup implementation on Android when the
feature is enabled. Preparation for Blink performing font-face { src:
local() } lookups correctly.

I have not found a good way to test this service on its own. Instead, I
aim to test font lookup through a browsertest once the font lookup is
hooked up in Blink. This would test the chain end to end. The
FontUniqueNameLookup implementation itself is tested extensively with
unit tests.

Bug:  868366 
Change-Id: Ie4f4cca88d6e98efdecfee04221cdb11d5b3c302
Reviewed-on: https://chromium-review.googlesource.com/1152970
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580122}
[modify] https://crrev.com/541bea6d4a914daec8710052b2c640bd05786046/content/browser/BUILD.gn
[modify] https://crrev.com/541bea6d4a914daec8710052b2c640bd05786046/content/browser/DEPS
[add] https://crrev.com/541bea6d4a914daec8710052b2c640bd05786046/content/browser/font_unique_name_lookup/font_unique_name_lookup_service.cc
[add] https://crrev.com/541bea6d4a914daec8710052b2c640bd05786046/content/browser/font_unique_name_lookup/font_unique_name_lookup_service.h
[modify] https://crrev.com/541bea6d4a914daec8710052b2c640bd05786046/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/541bea6d4a914daec8710052b2c640bd05786046/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/541bea6d4a914daec8710052b2c640bd05786046/third_party/blink/public/BUILD.gn
[add] https://crrev.com/541bea6d4a914daec8710052b2c640bd05786046/third_party/blink/public/platform/modules/font_unique_name_lookup/OWNERS
[add] https://crrev.com/541bea6d4a914daec8710052b2c640bd05786046/third_party/blink/public/platform/modules/font_unique_name_lookup/font_unique_name_lookup.mojom

Status: Fixed (was: Started)

Sign in to add a comment