Issue metadata
Sign in to add a comment
|
Menu option is not read in reading list when voiceover is on. |
||||||||||||||||||||||||
Issue descriptionApp Version: 69.0.3497.15 beta iOS Version: iOS 10.3.3,11.4,12 Device: iPhones Precondition : 1- Enable voice over from device settings. 2- Do Not have any reading list entries. Steps to reproduce: 1. Launch Chrome 2. Tap on Menu > Reading list 3. Scroll the cursor to “Your reading list is available offline” text Observed results: Menu button is not read. Expected results: Menu button should be read in voice over mode. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: Safari : NA Bug reproducible on the current beta channel build : No in M67 and M68 Bug reproducible on the current beta channel build : Yes in M70 Link to video/image: https://drive.google.com/file/d/1pkqm9n0ExAwGeKKJVyeG4BXYVKBCJYIc/view?usp=sharing
,
Aug 31
,
Aug 31
,
Sep 4
Fix has landed; marking next action date for canary verification.
,
Sep 5
The NextAction date has arrived: 2018-09-05
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/836f2b8f33a4c7a57581c22a5f79ad68857b4425 commit 836f2b8f33a4c7a57581c22a5f79ad68857b4425 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Tue Sep 04 21:45:51 2018 [iOS] Set a11y label for empty table view message. Since the reading list empty table message is an NSAttributedString that contains an embedded image, we need to apply a custom a11y label that correctly translates the image in the string to text. This CL adds the ability to update the empty message text a11y label. Bug: 868364 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Icc34396d7a30b5d82e7fd30eb1fd492d71d1e79d Reviewed-on: https://chromium-review.googlesource.com/1200077 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#588656} [modify] https://crrev.com/836f2b8f33a4c7a57581c22a5f79ad68857b4425/ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm [modify] https://crrev.com/836f2b8f33a4c7a57581c22a5f79ad68857b4425/ios/chrome/browser/ui/table_view/chrome_table_view_controller.h [modify] https://crrev.com/836f2b8f33a4c7a57581c22a5f79ad68857b4425/ios/chrome/browser/ui/table_view/chrome_table_view_controller.mm [modify] https://crrev.com/836f2b8f33a4c7a57581c22a5f79ad68857b4425/ios/chrome/browser/ui/table_view/table_view_empty_view.h [modify] https://crrev.com/836f2b8f33a4c7a57581c22a5f79ad68857b4425/ios/chrome/browser/ui/table_view/table_view_empty_view.mm
,
Sep 6
,
Sep 7
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aeeac192028199727da1be7237d7ecd5d550d1fd commit aeeac192028199727da1be7237d7ecd5d550d1fd Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Mon Sep 10 18:21:37 2018 [iOS] Set a11y label for empty table view message. Since the reading list empty table message is an NSAttributedString that contains an embedded image, we need to apply a custom a11y label that correctly translates the image in the string to text. This CL adds the ability to update the empty message text a11y label. Bug: 868364 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Icc34396d7a30b5d82e7fd30eb1fd492d71d1e79d Reviewed-on: https://chromium-review.googlesource.com/1200077 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588656}(cherry picked from commit 836f2b8f33a4c7a57581c22a5f79ad68857b4425) Reviewed-on: https://chromium-review.googlesource.com/1216852 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#230} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/aeeac192028199727da1be7237d7ecd5d550d1fd/ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm [modify] https://crrev.com/aeeac192028199727da1be7237d7ecd5d550d1fd/ios/chrome/browser/ui/table_view/chrome_table_view_controller.h [modify] https://crrev.com/aeeac192028199727da1be7237d7ecd5d550d1fd/ios/chrome/browser/ui/table_view/chrome_table_view_controller.mm [modify] https://crrev.com/aeeac192028199727da1be7237d7ecd5d550d1fd/ios/chrome/browser/ui/table_view/table_view_empty_view.h [modify] https://crrev.com/aeeac192028199727da1be7237d7ecd5d550d1fd/ios/chrome/browser/ui/table_view/table_view_empty_view.mm
,
Sep 11
Verified in 71.0.3549.0 Canary in iPhone X(iOS 11.4.1), iPhone 6s plus(iOS 12 beta 12) and iPad Air(iOS 12 beta 12) Menu option is now read in the “Your reading list is available offline” text. Looks good
,
Sep 14
Verified in 70.0.3538.17 beta in iPhone 6plus(iOS 11.4.1) and iPad Air(iOS 12 beta 12) Menu option is now read in the “Your reading list is available offline” text. Looks good |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by ghendel@google.com
, Aug 6