App crashes on clearing browsing data while the history items are syncing. |
|||||||||||
Issue descriptionApp Version: 69.0.3497.16 beta iOS Version: 12 beta 4, 11.4.1 Device: iPhone 8 plus, iPad URL: Precondition: Have history stored in a chrome account Steps to reproduce: 1. Launch chrome beta 2. Sign into chrome beta. 2. While the history items are syncing --> Go to Chrome Menu --> History --> Clear Browsing data --> Clear Browsing Data Scenario 2 : Launch chrome beta. Tap on the tab switcher > Scroll to recently closed. Tap on Show full history >Tap on Clear browsing data. Confirm Clear browsing data Observed results: App Crashes. Crash Log: https://crash.corp.google.com/browse?stbtiq=9f6479f423660927 Note: Issue is not reproducible with Old UI Expected results: App should not crash. Browser data should be cleared Number of times you were able to reproduce: 3/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): NA on M67 Bug reproducible on the current beta channel build (App Version, iOS Version): NA on M68 Link to video/image: https://drive.google.com/file/d/1RNT6f1bxdTlSI-v9r9boRFXp8i2UVb3p/view?usp=sharing STACK TRACE: Stack Quality84%Show frame trust levels 0x00000001cd65b700 (CoreFoundation + 0x0011e700 ) __exceptionPreprocess 0x00000001cc900d2c (libobjc.A.dylib + 0x00005d2c ) objc_exception_throw 0x00000001cd572520 (CoreFoundation + 0x00035520 ) -[NSObject(NSObject) doesNotRecognizeSelector:] 0x00000001f9802dd4 (UIKitCore + 0x00713dd4 ) -[UIResponder doesNotRecognizeSelector:] 0x00000001cd660d24 (CoreFoundation + 0x00123d24 ) ___forwarding___ 0x00000001cd662ce8 (CoreFoundation + 0x00125ce8 ) _CF_forwarding_prep_0 0x000000010300fdc4 (Chrome -clear_browsing_data_manager.mm:581 ) -[ClearBrowsingDataManager clearDataForDataTypes:] 0x000000010300e468 (Chrome -clear_browsing_data_manager.mm:246 ) __113-[ClearBrowsingDataManager actionSheetCoordinatorWithDataTypesToRemove:baseViewController:sourceRect:sourceView:]_block_invoke 0x0000000102a9a4f8 (Chrome -alert_coordinator.mm:84 ) __50-[AlertCoordinator addItemWithTitle:action:style:]_block_invoke 0x00000001f9425d6c (UIKitCore + 0x00336d6c ) -[UIAlertController _invokeHandlersForAction:] 0x00000001f9426730 (UIKitCore + 0x00337730 ) __103-[UIAlertController _dismissAnimated:triggeringAction:triggeredByPopoverDimmingView:dismissCompletion:]_block_invoke.467 0x00000001f978179c (UIKitCore + 0x0069279c ) -[UIPresentationController transitionDidFinish:] 0x00000001f97857ac (UIKitCore + 0x006967ac ) __56-[UIPresentationController runTransitionForCurrentState]_block_invoke.440 0x00000001f9b3b3cc (UIKitCore + 0x00a4c3cc ) -[_UIViewControllerTransitionContext completeTransition:] 0x00000001f9af0468 (UIKitCore + 0x00a01468 ) -[UIViewAnimationBlockDelegate _didEndBlockAnimation:finished:context:] 0x00000001f9ac5fe0 (UIKitCore + 0x009d6fe0 ) -[UIViewAnimationState sendDelegateAnimationDidStop:finished:] 0x00000001f9ac65cc (UIKitCore + 0x009d75cc ) -[UIViewAnimationState animationDidStop:finished:] 0x00000001f9ac666c (UIKitCore + 0x009d766c ) -[UIViewAnimationState animationDidStop:finished:] 0x00000001d1dd3698 (QuartzCore + 0x0014d698 ) CA::Layer::run_animation_callbacks(void*) 0x00000001cd094470 (libdispatch.dylib + 0x00062470 ) _dispatch_client_callout 0x00000001cd073560 (libdispatch.dylib + 0x00041560 ) _dispatch_main_queue_callback_4CF$VARIANT$armv81 0x00000001cd5e970c (CoreFoundation + 0x000ac70c ) __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ 0x00000001cd5e45a8 (CoreFoundation + 0x000a75a8 ) __CFRunLoopRun 0x00000001cd5e3ad4 (CoreFoundation + 0x000a6ad4 ) CFRunLoopRunSpecific 0x00000001cf84f56c (GraphicsServices + 0x0000b56c ) GSEventRunModal 0x00000001f9452754 (UIKitCore + 0x00363754 ) UIApplicationMain 0x00000001027e5f50 (Chrome -chrome_exe_main.mm:54 ) main 0x00000001cd0a4e50 (libdyld.dylib + 0x00000e50 ) start
,
Jul 30
-[ClearBrowsingDataTableViewController showBrowsingHistoryRemovedDialog]: unrecognized selector sent to instance 0x14ba1d520
,
Jul 30
Looks like that method was never implemented in the new table view controller. @thegreenfrog or @sczs, could you take a look at this?
,
Jul 30
Yep, already started! I think that method was only used for an experiment in the legacy implementation, thats why we didn't implemented it.
,
Jul 30
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f60b696f611392218fb10d6643276e82305ce483 commit f60b696f611392218fb10d6643276e82305ce483 Author: sczs <sczs@chromium.org> Date: Tue Jul 31 19:00:26 2018 [ios] Adds RemovedDialog alert to ClearBrowsingTableVC Implements showBrowsingHistoryRemovedDialog on ClearBrowsingDataTableVC. Screenshots: https://drive.google.com/open?id=1uMyVYUqzdikwfP7V-ka0xD3ImteYbKO2 https://drive.google.com/open?id=1blljYShc0UYPVOWeuZszFpWk1z3Es8ke https://drive.google.com/open?id=1J2r0pyARZtMOzjzffdL8B-S1ek8lBwXK Bug: 868363 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie0a20e07e64a3d14017e87edfa2dc05a874345f1 Reviewed-on: https://chromium-review.googlesource.com/1155479 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#579507} [modify] https://crrev.com/f60b696f611392218fb10d6643276e82305ce483/ios/chrome/browser/ui/settings/clear_browsing_data_consumer.h [modify] https://crrev.com/f60b696f611392218fb10d6643276e82305ce483/ios/chrome/browser/ui/settings/clear_browsing_data_table_view_controller.mm
,
Jul 31
,
Aug 1
,
Aug 1
vbarigela@ could you please verify? I was having a hard time reproducing the issue so I want to make sure.
,
Aug 7
Verified on chrome canary version 70.0.3515.0 on iPhone 8 plus with iOS 12 beta 6, and iPad Air with iOS 11.4.1, following steps mentioned in comment #0. No crashes observed. Looks good.
,
Aug 7
kariahda@ could you PTAL for manual approval?
,
Aug 7
This bug requires manual review: Less than 24 days to go before AppStore submit on M69 Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 7
Approved.
,
Aug 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf0b0a911cf532bf53937f0f4e441140c4798a1b commit bf0b0a911cf532bf53937f0f4e441140c4798a1b Author: sczs <sczs@chromium.org> Date: Tue Aug 07 18:06:52 2018 [ios] Adds RemovedDialog alert to ClearBrowsingTableVC Implements showBrowsingHistoryRemovedDialog on ClearBrowsingDataTableVC. Screenshots: https://drive.google.com/open?id=1uMyVYUqzdikwfP7V-ka0xD3ImteYbKO2 https://drive.google.com/open?id=1blljYShc0UYPVOWeuZszFpWk1z3Es8ke https://drive.google.com/open?id=1J2r0pyARZtMOzjzffdL8B-S1ek8lBwXK TBR=sczs@chromium.org (cherry picked from commit f60b696f611392218fb10d6643276e82305ce483) Bug: 868363 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie0a20e07e64a3d14017e87edfa2dc05a874345f1 Reviewed-on: https://chromium-review.googlesource.com/1155479 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#579507} Reviewed-on: https://chromium-review.googlesource.com/1165698 Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#469} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/bf0b0a911cf532bf53937f0f4e441140c4798a1b/ios/chrome/browser/ui/settings/clear_browsing_data_consumer.h [modify] https://crrev.com/bf0b0a911cf532bf53937f0f4e441140c4798a1b/ios/chrome/browser/ui/settings/clear_browsing_data_table_view_controller.mm
,
Aug 8
Verified in 69.0.3497.31 Beta, iPhone 7 iOS 12, iPad Air iOS11.4 Looks good |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by marq@chromium.org
, Jul 30Labels: -Pri-2 Q2 M-69 Pri-1
Owner: sczs@chromium.org
Status: Assigned (was: Untriaged)