New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 868333 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

CHECK failure: receiver->IsJSFunction() in objects.cc

Project Member Reported by ClusterFuzz, Jul 27

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5786025939697664

Fuzzer: ochang_js_fuzzer
Job Type: linux_d8_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  receiver->IsJSFunction() in objects.cc
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=54744:54745

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5786025939697664

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jul 27

Labels: Test-Predator-Auto-Owner
Owner: chandanreddy@google.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/4ef4deae6eb3277b0ce63908661bac9f64eea386 ([runtime] Change the default values of Proxy.prototype to undefined from null).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 27

Labels: Pri-1
Labels: Security_Impact-Head
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 28

Labels: M-69 Target-69
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 28

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 29

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 7 by ClusterFuzz, Aug 3

ClusterFuzz has detected this issue as fixed in range 54856:54857.

Detailed report: https://clusterfuzz.com/testcase?key=5786025939697664

Fuzzer: ochang_js_fuzzer
Job Type: linux_d8_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  receiver->IsJSFunction() in objects.cc
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=54744:54745
Fixed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=54856:54857

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5786025939697664

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Aug 3

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5786025939697664 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 9 by sheriffbot@chromium.org, Aug 3

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 10 by sheriffbot@chromium.org, Aug 5

Labels: Merge-Request-69
Project Member

Comment 11 by sheriffbot@chromium.org, Aug 5

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: awhalley@chromium.org
+awhalley@ (Security TPM) for M69 merge review. 
I don't see any cl here, is there anything to merge to M69?
The only CL in the fix range is: https://chromium.googlesource.com/v8/v8/+/92220026b2c4e490a78ca709e9cb9e336ef62e3a which is tracked as  issue 868473 . Could track the merge request (which LGTM) here or there I suppose.
Cc: hablich@chromium.org
+ hablich@, PTAL comment #14.
Labels: -Merge-Review-69 Merge-Approved-69
+1 to what Andrew said. Let's simply use this bug here.
Please merge this bug to 6.9. Instructions can be found at https://github.com/v8/v8/wiki/Merging-&-Patching
Cc: cbruni@chromium.org
Labels: -ReleaseBlock-Stable -Merge-Approved-69
This is solely a correctness issue.
There is a hard CHECK failure which means that there cannot be an exploit.

Given that the current fixes (all landed only in M70) cause some slight performance regressions, we decided to not do the backmerges.
Sounds good, thanks!
Project Member

Comment 22 by sheriffbot@chromium.org, Nov 9

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment