New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 868329 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

AEC3 transparency during call start and after echo path changes is non as good as it can be

Project Member Reported by peah@chromium.org, Jul 27

Issue description

The echo removal behavior in AEC3 during call startup and after echo path changes is too defensive, making the near-end transparency worse than it can be.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/f954ba5c1112191fc048f566eb3b407e6e1152da

commit f954ba5c1112191fc048f566eb3b407e6e1152da
Author: Per Åhgren <peah@webrtc.org>
Date: Fri Jul 27 14:18:42 2018

AEC3: Increasing the transparency during call startup

This CL increases the AEC3 transparency during call
startup and after echo path delay changes in 3 ways:
1. The exit requirements for the initial mode is
made less strict.
2. The requirements for using the linear echo model
are made less strict.
3. The duplicated reverb modelling in the linear mode
removed.


Bug:  webrtc:9572 , chromium:868329 
Change-Id: I79ea0796ed26408e35576bb39eaae4e4848b4f83
Reviewed-on: https://webrtc-review.googlesource.com/90868
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24132}
[modify] https://crrev.com/f954ba5c1112191fc048f566eb3b407e6e1152da/modules/audio_processing/aec3/aec_state.cc
[modify] https://crrev.com/f954ba5c1112191fc048f566eb3b407e6e1152da/modules/audio_processing/aec3/aec_state.h
[modify] https://crrev.com/f954ba5c1112191fc048f566eb3b407e6e1152da/modules/audio_processing/aec3/residual_echo_estimator.cc
[modify] https://crrev.com/f954ba5c1112191fc048f566eb3b407e6e1152da/modules/audio_processing/aec3/residual_echo_estimator.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2919a4bd612b65f0d5351fbe2d9bdc310d2a02dc

commit 2919a4bd612b65f0d5351fbe2d9bdc310d2a02dc
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jul 27 22:51:28 2018

Roll src/third_party/webrtc e4db6a151806..e635e9807dab (19 commits)

https://webrtc.googlesource.com/src.git/+log/e4db6a151806..e635e9807dab


git log e4db6a151806..e635e9807dab --date=short --no-merges --format='%ad %ae %s'
2018-07-27 ouj@fb.com Fix compilation error of opensslutility.cc when compiling with OpenSSL.
2018-07-27 saza@webrtc.org Remove old temporary webrtc::PostProcessing typedef
2018-07-27 titovartem@webrtc.org Revert "Add framesRendered to StatsReport"
2018-07-27 mbonadei@webrtc.org Remove dependency between source_set and android_library.
2018-07-27 peah@webrtc.org AEC3: Increasing the transparency during call startup
2018-07-27 saza@webrtc.org Fuzz unfuzzed AEC3 killswitch field trials
2018-07-27 buildbot@webrtc.org Roll chromium_revision d340c5e1a4..75645bae58 (578434:578612)
2018-07-27 saza@webrtc.org Add unused AEC toggling config to API
2018-07-27 jbauch@webrtc.org Don't use explicit constructor in copy-initialization.
2018-07-27 titovartem@webrtc.org Fix android DEPS to unblock chromium roll
2018-07-27 oprypin@webrtc.org Don't specify Mac version for iOS real device tests
2018-07-27 titovartem@webrtc.org Fix chromium roll by manually rolling up to d340c5e1a4
2018-07-27 nisse@webrtc.org Delete logic to look for arch-specific resource files.
2018-07-27 nisse@webrtc.org Delete lsan and valgrind suppressions for deleted xmpp tests
2018-07-27 titovartem@webrtc.org Fix refered LICENSE file path in webrtc license notice
2018-07-26 joachimr@fb.com Add framesRendered to StatsReport
2018-07-26 qingsi@google.com Use "wildcard" instead of "unknown" for ADAPTER_TYPE_ANY in stats.
2018-07-26 buildbot@webrtc.org Roll chromium_revision 9617755102..16fdc86042 (578286:578405)
2018-07-26 mbonadei@webrtc.org Enable clang::find_bad_constructs for call/ (part 1).


Created with:
  gclient setdep -r src/third_party/webrtc@e635e9807dab

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:868329,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I85c516ab6a287e01072aa19a814098cad157abbd
Reviewed-on: https://chromium-review.googlesource.com/1153512
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578840}
[modify] https://crrev.com/2919a4bd612b65f0d5351fbe2d9bdc310d2a02dc/DEPS

We would like to merge this issue into M69. It addresses an important issue in the echo canceller that was emphasized with some of the changes done for M69.

It has been tested in Chrome Canary and both the manual testing results and the metrics look good. The merge is considered to be very safe, as the feature is only active beneath an experiment flag, and also has a specific kill-switch.

The CL that would be part of the merge is
-https://webrtc-review.googlesource.com/90868

Since this functionality has been tested together with the functionalities in 
-https://bugs.chromium.org/p/chromium/issues/detail?id=867873
-https://bugs.chromium.org/p/chromium/issues/detail?id=867373
we have also asked for merges of those.

Cc: gustaf@chromium.org hlundin@chromium.org
Labels: Merge-Request-69
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 30

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-69 Merge-Approved-69
Approving merge to M69 branch 3497 based on comment #3. Please merge ASAP. Thank you.
Labels: -Merge-Approved-69 Merge-Merged Merge-Merged-69
This issue has been merged to M69.

The merging CL was
-https://webrtc-review.googlesource.com/c/src/+/91262
Labels: M-69
Status: Fixed (was: Started)

Sign in to add a comment