New issue
Advanced search Search tips

Issue 868308 link

Starred by 1 user
Status: Duplicate
Merged: issue 833380
Owner:
mcnee@chromium.org
Closed: Jul 30
Cc:
nzolghadr@chromium.org
chaopeng@chromium.org
sadrul@chromium.org
riajiang@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"SitePerProcessHitTestBrowserTest.TouchpadPinchOverOOPIF/0" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jul 27 
"SitePerProcessHitTestBrowserTest.TouchpadPinchOverOOPIF/0" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 6 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRAsSBUZsYWtlIjlTaXRlUGVyUHJvY2Vzc0hpdFRlc3RCcm93c2VyVGVzdC5Ub3VjaHBhZFBpbmNoT3Zlck9PUElGLzAM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by smcgruer@chromium.org, Jul 27

Components: -Tests>Flaky Blink>Input
Owner: nzolghadr@chromium.org
Status: Assigned (was: Untriaged)
nzolghadr@, PTAL as I believe this is input related.

The test seems to be failing on windows both with timeouts (https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8939898542119355616/+/steps/viz_content_browsertests__with_patch__on_Windows-10-15063/0/logs/SitePerProcessHitTestBrowserTest.TouchpadPinchOverOOPIF__x2f_0/0, looks like timeout) and with crashes (https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8939900056613756128/+/steps/network_service_content_browsertests__with_patch__on_Windows-10-15063/0/logs/SitePerProcessHitTestBrowserTest.TouchpadPinchOverOOPIF__x2f_0/0):

../../content/browser/site_per_process_hit_test_browsertest.cc(3266): error: Value of: target_monitor.EventWasReceived()
  Actual: false
Expected: true
Stack trace:
Backtrace:
	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x00007FF62823DFD7+87]
	testing::internal::AssertHelper::operator= [0x00007FF62823DB5E+78]
	content::SitePerProcessHitTestBrowserTest_InputEventRouterTouchpadGestureTargetTest_Test::RunTestOnMainThread [0x00007FF62797236D+2717]
	content::SitePerProcessHitTestBrowserTest_TouchpadPinchOverOOPIF_Test::RunTestOnMainThread [0x00007FF627972D14+1188]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF629BF333B+507]
	content::ShellBrowserMainParts::PreMainMessageLoopRun [0x00007FF62A6E692F+79]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x00007FF628661275+85]
	content::StartupTaskRunner::RunAllTasksNow [0x00007FF628A645A5+37]
	content::BrowserMainLoop::CreateStartupTasks [0x00007FF62865FB33+803]
	content::BrowserMainRunnerImpl::Initialize [0x00007FF628663A3E+126]
	ShellBrowserMain [0x00007FF62CE7539D+45]
	content::ShellMainDelegate::RunProcess [0x00007FF62CE73A8A+218]
	content::RunBrowserProcessMain [0x00007FF628571B09+89]
	content::ContentMainRunnerImpl::Run [0x00007FF6285725E0+752]
	service_manager::Main [0x00007FF62A1F0F60+2000]
	content::ContentMain [0x00007FF628571A51+65]
	content::BrowserTestBase::SetUp [0x00007FF629BF2FF6+2198]
	content::ContentBrowserTest::SetUp [0x00007FF629BE9A28+136]
[792:4260:0726/154933.750:FATAL:site_per_process_hit_test_browsertest.cc(104)] Check failed: EventWasReceived().


Confusingly it looks like this test is part of multiple test suites: network_service_content_browsertests, content_browsertests, and viz_content_browsertests?

Comment 2 by nzolghadr@chromium.org, Jul 27

Cc: sadrul@chromium.org nzolghadr@chromium.org
Owner: chaopeng@chromium.org
Assigning to Chao as he is our expert for Touchpad events.
Also cc'ing Sadrul in case he had some suggestions.

Comment 3 by chaopeng@chromium.org, Jul 27

Cc: chaopeng@chromium.org
Owner: mcnee@chromium.org

Comment 4 by mcnee@chromium.org, Jul 27

Cc: riajiang@chromium.org
Versions /1 and /2 were previously found to be flaky in issue 853761 .
Project Member

Comment 5 by chromium...@appspot.gserviceaccount.com, Jul 28 

Detected 5 new flakes for test/step "SitePerProcessHitTestBrowserTest.TouchpadPinchOverOOPIF/0". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRAsSBUZsYWtlIjlTaXRlUGVyUHJvY2Vzc0hpdFRlc3RCcm93c2VyVGVzdC5Ub3VjaHBhZFBpbmNoT3Zlck9PUElGLzAM. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 6 by chromium...@appspot.gserviceaccount.com, Jul 30 

Detected 3 new flakes for test/step "SitePerProcessHitTestBrowserTest.TouchpadPinchOverOOPIF/0". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRAsSBUZsYWtlIjlTaXRlUGVyUHJvY2Vzc0hpdFRlc3RCcm93c2VyVGVzdC5Ub3VjaHBhZFBpbmNoT3Zlck9PUElGLzAM. This message was posted automatically by the chromium-try-flakes app.

Comment 7 by mcnee@chromium.org, Jul 30

Mergedinto: 833380
Status: Duplicate (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0793f8f7f919da4d4ceba5712cd1790ab15c3532

commit 0793f8f7f919da4d4ceba5712cd1790ab15c3532
Author: Peter Boström <pbos@chromium.org>
Date: Mon Jul 30 18:35:29 2018

Disable TouchpadPinchOverOOPIF tests on Windows

SitePerProcessHitTestBrowserTest.TouchpadPinchOverOOPIF is being
reported as flaky on Windows.

Bug:  chromium:868308 ,  chromium:833380 
TBR: kenrb@chromium.org
Change-Id: I83142d0d777bbe51773eaba0ab1d191a4af0cbc5
Reviewed-on: https://chromium-review.googlesource.com/1155165
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579096}
[modify] https://crrev.com/0793f8f7f919da4d4ceba5712cd1790ab15c3532/content/browser/renderer_host/render_widget_host_input_event_router.h
[modify] https://crrev.com/0793f8f7f919da4d4ceba5712cd1790ab15c3532/content/browser/site_per_process_hit_test_browsertest.cc
►

Sign in to add a comment