Issue metadata
Sign in to add a comment
|
Certain build configuration broken on Windows by recent download db patch
Reported by
oetu...@nvidia.com,
Jul 27
|
||||||||||||||||||||||||
Issue description
Chrome Version: 70.0.3505.0
OS: Win10
What steps will reproduce the problem?
(1) Use the following args.gn, non-Googler build tools (DEPOT_TOOLS_WIN_TOOLCHAIN=0):
is_component_build = true
is_debug = false
enable_nacl = false
target_cpu = "x64"
remove_webcore_debug_symbols = true
use_jumbo_build = true
(2) Build "chrome" build target
What is the expected result?
Chrome builds successfully.
What happens instead?
The following kind of error message is reported when compiling components/download/database/download_db.cc:
../..\components/download/database/download_db.h(23,12): error: no template named 'unique_ptr' in namespace 'std'
std::unique_ptr<std::vector<DownloadDBEntry>> entries)>;
~~~~~^
../../components/download/database/download_db.cc(26,23): error: no matching member function for call to 'Run'
std::move(callback).Run(true,
~~~~~~~~~~~~~~~~~~~~^~~
../..\base/callback.h(91,5): note: candidate function not viable: no known conversion from 'unique_ptr<std::vector<download::DownloadDBEntry, std::allocator<download::DownloadDBEntry> > >' to 'int' for 2nd argument
R Run(Args... args) && {
^
../..\base/callback.h(84,5): note: candidate function not viable: no known conversion from 'unique_ptr<std::vector<download::DownloadDBEntry, std::allocator<download::DownloadDBEntry> > >' to 'int' for 2nd argument
R Run(Args... args) const & {
^
2 errors generated.
This seems to be a regression from: https://chromium-review.googlesource.com/c/chromium/src/+/1147604
If I revert that patch, then the code compiles fine.
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by oetu...@nvidia.com
, Jul 27Status: Duplicate (was: Available)