New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 868287 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Tracker bug for task tagging for power data in power test

Project Member Reported by seankao@google.com, Jul 27

Issue description

Tag power data with information about the tasks that contribute to the measured power data.

Design Proposal: go/cros-power-tag
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/38cf8f05a26c105991f8e85466fa7b3fb9b75cd5

commit 38cf8f05a26c105991f8e85466fa7b3fb9b75cd5
Author: Sean Kao <seankao@google.com>
Date: Tue Aug 07 14:31:22 2018

power_LoadTest: Record timestamps, send to client debug log

end_load_time and end_browse_time are set to null on page start,
to clearly indicate that something went wrong with the page
(or with the code) if either of them is null in the log.

BUG= chromium:868287 
TEST=run power_LoadTest.1hour, check client debug log

Change-Id: I5d00a44a992dc530d042587a540c5252a6d968b3
Signed-off-by: Sean Kao <seankao@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1152845
Tested-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>

[modify] https://crrev.com/38cf8f05a26c105991f8e85466fa7b3fb9b75cd5/client/site_tests/power_LoadTest/extension/test.js
[modify] https://crrev.com/38cf8f05a26c105991f8e85466fa7b3fb9b75cd5/client/site_tests/power_LoadTest/power_LoadTest.py

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a025231363bc0cecfe3008799a9a7faa2245df6c

commit a025231363bc0cecfe3008799a9a7faa2245df6c
Author: Sean Kao <seankao@google.com>
Date: Wed Aug 08 13:43:03 2018

power_LoadTest: Refactor page load time tracking

- page_load_time tracking related code is now merged into
page_time tracking code
- unique url salt is only added before POSTing, rather
than added in the 'url' field of page dictionary

BUG= chromium:868287 
TEST=run power_LoadTest.fast and check keyval in
results directory, search for ex_ms_page_load_time

Change-Id: I39fa9bddde438b6384daa0488b52a500897b2b00
Signed-off-by: Sean Kao <seankao@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1152846
Commit-Ready: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Tested-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>

[modify] https://crrev.com/a025231363bc0cecfe3008799a9a7faa2245df6c/client/site_tests/power_LoadTest/extension/test.js
[modify] https://crrev.com/a025231363bc0cecfe3008799a9a7faa2245df6c/client/site_tests/power_LoadTest/power_LoadTest.py

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1222c95e02bf20dcee338405b580ecafc6fbb15d

commit 1222c95e02bf20dcee338405b580ecafc6fbb15d
Author: Sean Kao <seankao@google.com>
Date: Thu Aug 16 03:35:52 2018

power_LoadTest: Use checkpoint for web browse tagging

url is sanitized to match key syntax for checkpoint
checkpoint data is stored in results directory

BUG= chromium:868287 
TEST=Run power_LoadTest.fast and check keyval in
results directory, search for 'web_page_'.
Most of them will have no useful data becuase their
durations are too short.
Check checkpoint_log.json for checkpoint data.

Change-Id: I09fd0d011f623ddf5b51bcb59346e8c883d3ad84
Signed-off-by: Sean Kao <seankao@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1160134
Tested-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>

[modify] https://crrev.com/1222c95e02bf20dcee338405b580ecafc6fbb15d/client/site_tests/power_LoadTest/extension/test.js
[modify] https://crrev.com/1222c95e02bf20dcee338405b580ecafc6fbb15d/client/cros/power/power_status.py
[modify] https://crrev.com/1222c95e02bf20dcee338405b580ecafc6fbb15d/client/site_tests/power_LoadTest/power_LoadTest.py

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/29c0f67184dd9605e2e3b7397f3088ef4c9ff2b8

commit 29c0f67184dd9605e2e3b7397f3088ef4c9ff2b8
Author: Sean Kao <seankao@google.com>
Date: Thu Aug 16 03:35:53 2018

power_status: Let a tag contain several time intervals

BUG= chromium:868287 
TEST=Run power_LoadTest.fast, check results for
docs.google.com

Change-Id: I0454bb8abf44287d8e20bfe59729392cc8517b2f
Signed-off-by: Sean Kao <seankao@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1163418
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/29c0f67184dd9605e2e3b7397f3088ef4c9ff2b8/client/cros/power/power_status.py

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0ce9d648951972321f99febbf6c91169c0485414

commit 0ce9d648951972321f99febbf6c91169c0485414
Author: Sean Kao <seankao@google.com>
Date: Fri Aug 17 18:18:03 2018

power_status: Static method to load checkpoint data

BUG= chromium:868287 
TEST=no need

Change-Id: Ia4aa1aa311e4e689f085b988eab595e0c7c2bc65
Signed-off-by: Sean Kao <seankao@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1164870
Tested-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>

[modify] https://crrev.com/0ce9d648951972321f99febbf6c91169c0485414/client/cros/power/power_status.py

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/50714ced31ed2ecf49fae9d25f33cd86e4811c15

commit 50714ced31ed2ecf49fae9d25f33cd86e4811c15
Author: Puthikorn Voravootivat <puthik@chromium.org>
Date: Thu Oct 18 21:53:50 2018

power_LoadTest: Improve checkpoint

This CL improves checkpoint for power_LoadTest by
- Mark unimportant checkpoint with underscore prefix.
- Add browsing/email/document/video checkpoints in
  60/20/20/10 ratio on loop runtime.

BUG= chromium:868287 
TEST=PLT.fast now have meaningful checkpoint

Change-Id: I9f29aab4024893901d86bfa92573546981aba4bd
Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1277972
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>

[modify] https://crrev.com/50714ced31ed2ecf49fae9d25f33cd86e4811c15/client/site_tests/power_LoadTest/power_LoadTest.py

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cef591a2584117fecca92ec76383395e0e87bb51

commit cef591a2584117fecca92ec76383395e0e87bb51
Author: Puthikorn Voravootivat <puthik@chromium.org>
Date: Wed Oct 24 02:22:02 2018

power_LoadTest: Don't send bad data to power dashboard

This CL does the following to improve power dashboard data.
- Don't upload data to dashboard if PLT didn't finish 1 loop.
  This would pollute average power for that test config.
- Tag checkpoint to last loop using 60/20/10/10 ratio of
  full loop duration instead of that loop duration.
- Use start time from extension if exists.

BUG= chromium:868287 
TEST=manual. no longer upload incomplete loop.

Change-Id: I119138c2a243431943e44bf6ae89666d614f72f8
Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1285529
Reviewed-by: Mengqi Guo <mqg@chromium.org>

[modify] https://crrev.com/cef591a2584117fecca92ec76383395e0e87bb51/client/site_tests/power_LoadTest/power_LoadTest.py

Sign in to add a comment