New issue
Advanced search Search tips

Issue 868280 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

`git cl split` does not work when metrics collection is enabled

Project Member Reported by tikuta@chromium.org, Jul 27

Issue description

Only first part of CL is uploaded.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/6f812e132d25df1b561f7182b04903004a3055e4

commit 6f812e132d25df1b561f7182b04903004a3055e4
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Tue Jul 31 22:45:57 2018

metrics: Separate metrics collection and print notice logic.

As it is right now, when a function is collecting metrics it prints
the notice and calls sys.exit() to ensure the notice is the last thing
that is printed.

git-cl split has to call git-cl upload multiple times, but once it has
been called once, it exits, so only the first cl is uploaded.

This separates metrics collection from notice printing, so that the
function that is collecting metrics behaves like a function that isn't.
It also makes sure we don't collect metrics for multiple functions at
the same time.

Bug:  868280 
Change-Id: Ic58ebe7d19e09ed85fa8b0af76dcbf608ee4c9bc
Reviewed-on: https://chromium-review.googlesource.com/1153503
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/6f812e132d25df1b561f7182b04903004a3055e4/metrics.py
[modify] https://crrev.com/6f812e132d25df1b561f7182b04903004a3055e4/git_nav_downstream.py
[modify] https://crrev.com/6f812e132d25df1b561f7182b04903004a3055e4/tests/metrics_test.py
[modify] https://crrev.com/6f812e132d25df1b561f7182b04903004a3055e4/gclient.py
[modify] https://crrev.com/6f812e132d25df1b561f7182b04903004a3055e4/git_cl.py

Status: Fixed (was: Untriaged)
Should be fixed now.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d12dcf27a490d87b8681593aff46e13381cd3e0

commit 2d12dcf27a490d87b8681593aff46e13381cd3e0
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Aug 01 02:33:54 2018

Roll src/third_party/depot_tools 1aefad2a5982..6f812e132d25 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1aefad2a5982..6f812e132d25


git log 1aefad2a5982..6f812e132d25 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 ehmaldonado@chromium.org metrics: Separate metrics collection and print notice logic.


Created with:
  gclient setdep -r src/third_party/depot_tools@6f812e132d25

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:868280 
TBR=agable@chromium.org

Change-Id: I2372686119cd531c28d4aa1c947f20242b5493ba
Reviewed-on: https://chromium-review.googlesource.com/1157485
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579674}
[modify] https://crrev.com/2d12dcf27a490d87b8681593aff46e13381cd3e0/DEPS

Thanks!

Sign in to add a comment