New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 868274 link

Starred by 1 user
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Aug 1
Cc:
█ manoranj...@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : 'Manage..' link does not work in 'Select a destination' overlay.

Reported by avsha...@etouch.net, Jul 27 
Chrome Version : 70.0.3504.0 (Official Build) caaa08e92d8d9e71ab033d902165bb9859bb15f2-refs/branch-heads/3504@{#1} 32/64 bit
OS : Windows (7, 8, 8.1, 10)

Precondition : Enable #enable-new-print-preview flag from chrome://flags

What steps will reproduce the problem?
1. Launch chrome, open NTP and hit Ctrl + P to open print preview window.
2. Click on 'Change..' button under 'Destination' section and try to click on 'Manage' button in 'Select a destination' overlay.
3. Observe.

Actual Result : 'Manage..' button does not work in 'Select a destination' overlay.

Expected Result : 'Manage..' button should work as expected.

This is a regression issue broken in ‘M-70’ and will soon update other details. 
Good Build : 70.0.3501.0 (Revision : 577394)
Bad Build : 70.0.3502.3 (Revision : 577759)
Actual_Result.mp4
649 KB View Download
Expected_Result.mp4
613 KB View Download

Comment 1 by avsha...@etouch.net, Jul 27

Labels: RegressedIn-70 Target-70 FoundIn-70 hasbisect OS-Linux
Owner: rbpotter@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Regression : 'Manage..' link does not work in 'Select a destination' overlay. (was: Regression : 'Manage..' button does not work in 'Select a destination' overlay.)
This is a regression issue broken in ‘M-70’ and below is the bisect info:
Good Build : 70.0.3501.0 (Revision : 577394)
Bad Build : 70.0.3502.3 (Revision : 577759)

(Unable to narrow down the range using per-revision bisect, hence providing bisect using old script)

Narrow bisect URL :
https://chromium.googlesource.com/chromium/src/+log/aba6c716b4a3daf5c5d47017c16265c15981081f..fc566d1c1a2d8da82ccce610b153f3b54524eab4

Suspecting : r577742

rbpotter@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1. Able to reproduce issue in Linux(14.04 LTS) OS.
2. This issue is not observed in Mac(10.12.6, 10.13.1, 10.14, 10.13.6) OS

Comment 2 by nyerramilli@chromium.org, Jul 27

Cc: manoranj...@chromium.org
Labels: ReleaseBlock-Stable
marking as RBS please change if required

Comment 3 by rbpotter@chromium.org, Jul 27 

Interestingly, as far as I can tell this only reproduces when the user has no recent destinations (i.e. new profile). If there are any recent destinations, the link works. Seems related to iron-list having a fixed height, and getting pushed down by the "No destinations" message.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ce7d0c39280cae19ed40f753bb0c717b05aea10

commit 9ce7d0c39280cae19ed40f753bb0c717b05aea10
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Jul 31 03:32:19 2018

Print Preview: Fix manage link

If the "No destinations" message was visible in the recent destinations
list, the iron-list containing the destinations was pushed down and
extended invisibly over the "Manage" link for the print destinations,
preventing the link from working.

Fix this by ensuring that the iron-lists are the correct height: height
of the parent - height of parent's header line - height of "No
destinations" message (if showing).

Bug:  868274 
Change-Id: Idf574923d69ae1c0ff1265efe62b9cc67b70af11
Reviewed-on: https://chromium-review.googlesource.com/1153430
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579306}
[modify] https://crrev.com/9ce7d0c39280cae19ed40f753bb0c717b05aea10/chrome/browser/resources/print_preview/new/destination_list.html
[modify] https://crrev.com/9ce7d0c39280cae19ed40f753bb0c717b05aea10/chrome/browser/resources/print_preview/new/destination_list.js

Comment 5 by rbpotter@chromium.org, Aug 1

Status: Fixed (was: Assigned)

Comment 6 by avsha...@etouch.net, Aug 2

Labels: TE-Verified-M70 TE-Verified-70.0.3510.0 TE-Verified-70.0.3510.2
Update :
Tested above issue in latest Canary build #70.0.3510.2 on Windows(7, 8, 8.1, 10) & Linux(14.04 LTS) OS (in build #70.0.3510.0) and the issue is fixed. Now, 'Manage' link in Print Preview window works as expected, hence adding TE-Verified labels. Kindly review an attached screen-cast for reference.

Thank you..!
Latest_behaviour.mp4
677 KB View Download
►

Sign in to add a comment