New issue
Advanced search Search tips

Issue 868271 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Uninitialized object access lead to SIGSEGV in CXFA_LocaleMgr::GetDefLocale

Reported by zhouat2...@gmail.com, Jul 27

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.75 Safari/537.36

Steps to reproduce the problem:
1. pdfium

git log
commit aa418e541589f6c1f6462b383f3f35d246d6eabe
Author: Lei Zhang <thestig@chromium.org>
Date:   Fri Jul 27 01:13:16 2018 +0000

2. XFA build

3. poc file
SIGSEGV_in_CXFA_LocaleMgr_GetDefLocale.pdf

What is the expected behavior?

What went wrong?
Segmentation fault

Did this work before? N/A 

Chrome version: 68.0.3440.75  Channel: stable
OS Version: OS X 10.13.4
Flash Version:
 

Comment 1 Deleted

Comment 2 Deleted

Project Member

Comment 3 by ClusterFuzz, Jul 27

ClusterFuzz is analyzing your testcase. Developers can follow the progress at https://clusterfuzz.com/testcase?key=5690715959721984.
Project Member

Comment 4 by ClusterFuzz, Jul 27

ClusterFuzz is analyzing your testcase. Developers can follow the progress at https://clusterfuzz.com/testcase?key=6737246909366272.
Cc: mbarbe...@chromium.org
Components: Internals>Plugins>PDF
Owner: dsinclair@chromium.org
Status: Assigned (was: Unconfirmed)
I've confirmed this locally in an msan build but it just seems like a null dereference to me.

dsinclair: Would you mind taking a look at this? I'll remove this from the security queue soon if there are no objections.
Owner: thestig@chromium.org
Labels: -Type-Bug-Security -Restrict-View-SecurityTeam Type-Bug
CXFA_LocaleValue::m_pLocaleMgr is a nullptr.
Cc: mbarbella@google.com tsepez@chromium.org
 Issue 868669  has been merged into this issue.
Project Member

Comment 9 by ClusterFuzz, Jul 30

Labels: Security_Impact-Head
Summary: <no crash state available> (was: Uninitialized object access lead to SIGSEGV in CXFA_LocaleMgr::GetDefLocale)
Testcase 5690715959721984 failed to reproduce the crash. Please inspect the program output at https://clusterfuzz.com/testcase?key=5690715959721984.
Project Member

Comment 10 by ClusterFuzz, Jul 30

Testcase 6737246909366272 failed to reproduce the crash. Please inspect the program output at https://clusterfuzz.com/testcase?key=6737246909366272.
Summary: Uninitialized object access lead to SIGSEGV in CXFA_LocaleMgr::GetDefLocale (was: <no crash state available>)
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/0ac36018b464f74419b8b8e77d9452b41440187a

commit 0ac36018b464f74419b8b8e77d9452b41440187a
Author: Lei Zhang <thestig@chromium.org>
Date: Wed Aug 01 08:13:55 2018

Fix a nullptr crash in CXFA_LocaleValue::ValidateValue().

Fix some nits as well.

BUG= chromium:868271 

Change-Id: Ia3231fde98c3e16e41b092a9833402cedc8e828d
Reviewed-on: https://pdfium-review.googlesource.com/39112
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/0ac36018b464f74419b8b8e77d9452b41440187a/xfa/fxfa/parser/cxfa_localevalue.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f016c04f442423826b51f961c4b2e15069036cdb

commit f016c04f442423826b51f961c4b2e15069036cdb
Author: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Aug 01 09:59:51 2018

Roll src/third_party/pdfium 53d4f0a4526e..d4906e83d313 (2 commits)

https://pdfium.googlesource.com/pdfium.git/+log/53d4f0a4526e..d4906e83d313


git log 53d4f0a4526e..d4906e83d313 --date=short --no-merges --format='%ad %ae %s'
2018-08-01 thestig@chromium.org Combine date/time format methods in CFXJSE_FormCalcContext.
2018-08-01 thestig@chromium.org Fix a nullptr crash in CXFA_LocaleValue::ValidateValue().


Created with:
  gclient setdep -r src/third_party/pdfium@d4906e83d313

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:868271 
TBR=dsinclair@chromium.org

Change-Id: If30315876994c44b83e73e920811987e45fd323b
Reviewed-on: https://chromium-review.googlesource.com/1158127
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579744}
[modify] https://crrev.com/f016c04f442423826b51f961c4b2e15069036cdb/DEPS

Project Member

Comment 15 by ClusterFuzz, Aug 2

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6066354202083328 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment