New issue
Advanced search Search tips

Issue 868270 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Tab Grid Tiles incorrect offset after Closing/ Opening Chrome and Rotating Device

Project Member Reported by martijnb@chromium.org, Jul 27

Issue description

See video

(1) Go to NTP 
(2) Close Chrome App
(3) Open Chrome App
(4) Rotate Device
(5) Rotate Device Again
(6) Enter Tab Grid

Tiles now have an incorrect offset. 




 
ScreenRecording_07-27-2018 11-37-06.MP4
7.9 MB View Download
Cc: thegreenfrog@chromium.org
Labels: -Pri-3 Q-2 Pri-1
Owner: marq@chromium.org
Status: Assigned (was: Untriaged)
Labels: -proj-uifresh MS-Tab-Grid Proj-UIRefresh
Owner: thegreenfrog@chromium.org
Labels: M-69
Status: Started (was: Assigned)
Labels: -Q-2 Q2
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65fd3130d06c8d9abcd633a341dd705eb105793a

commit 65fd3130d06c8d9abcd633a341dd705eb105793a
Author: Chris Lu <thegreenfrog@chromium.org>
Date: Tue Jul 31 23:29:54 2018

[ios] Fix Tabgrid UI imperfections

- Moves GridViewCntroller inset adjustments in -viewDidAppear and -willTransitionToSize to -viewDidlayoutSubviews. The tradeoffs is that -viewDidLayoutSubviews is called many more times than the other two, hence the original choice to stay away from it. However, the current approach gives a glitchy-like UI experience when rotating.
- Updates Remote Tabs insets with horizontal safe area of scroll view if not on the screen. Doesn't update insets if visible since it will then have the right safe area already. This is still a hack, but a more comprehensive coverage so that it never ends up encroaching the safe area.

Video: https://drive.google.com/open?id=1jzP0ClCOn0uQTZC9hJ2g0FUWsF-nSuqV

Bug:  868270 ,  868285 , 868658
Change-Id: Ia50146e1be9dfdde74bbf3e7d6b6042168b2ce8a
Reviewed-on: https://chromium-review.googlesource.com/1153391
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579618}
[modify] https://crrev.com/65fd3130d06c8d9abcd633a341dd705eb105793a/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm
[modify] https://crrev.com/65fd3130d06c8d9abcd633a341dd705eb105793a/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

Status: Fixed (was: Started)
Verified on Canary on 8/1
Labels: Merge-TBD
Does this need to be merged to M69?
Labels: -Merge-TBD Merge-Approved-69
Approved.
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 2

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/711f9aeae17c8e1fbc17802688113520c1fb4637

commit 711f9aeae17c8e1fbc17802688113520c1fb4637
Author: sczs <sczs@chromium.org>
Date: Thu Aug 02 16:41:36 2018

[ios] Fix Tabgrid UI imperfections

- Moves GridViewCntroller inset adjustments in -viewDidAppear and -willTransitionToSize to -viewDidlayoutSubviews. The tradeoffs is that -viewDidLayoutSubviews is called many more times than the other two, hence the original choice to stay away from it. However, the current approach gives a glitchy-like UI experience when rotating.
- Updates Remote Tabs insets with horizontal safe area of scroll view if not on the screen. Doesn't update insets if visible since it will then have the right safe area already. This is still a hack, but a more comprehensive coverage so that it never ends up encroaching the safe area.

Video: https://drive.google.com/open?id=1jzP0ClCOn0uQTZC9hJ2g0FUWsF-nSuqV

TBR=thegreenfrog@chromium.org

(cherry picked from commit 65fd3130d06c8d9abcd633a341dd705eb105793a)

Bug:  868270 ,  868285 , 868658
Change-Id: Ia50146e1be9dfdde74bbf3e7d6b6042168b2ce8a
Reviewed-on: https://chromium-review.googlesource.com/1153391
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579618}
Reviewed-on: https://chromium-review.googlesource.com/1160875
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#337}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/711f9aeae17c8e1fbc17802688113520c1fb4637/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm
[modify] https://crrev.com/711f9aeae17c8e1fbc17802688113520c1fb4637/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

Status: Verified (was: Fixed)
Verified in build 69.0.3497.31 Beta on iPhoneX iOS 11.4, iPhone 7+ iOS 10.3.3

Sign in to add a comment