New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 868263 link

Starred by 1 user
Status: Verified
Owner:
█ hunyadym@chromium.org
Last visit > 30 days ago
Closed: Jul 31
Cc:
zentaro@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Reboot and reset button does nothing for Chrome OS enterprise rollback

Project Member Reported by hunyadym@chromium.org, Jul 27 
What steps will reproduce the problem?
(1) Initiate enterprise rollback
(2) Click on "Reboot and reset" button on the update page

What is the expected result?
Device reboots.

What happens instead?
Device doesn't reboot, because allow_powerwash is false, because device is enterprise managed. (https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/settings/browser_lifetime_handler.cc?l=108&rcl=961775510291644dac141cf54adbcbba297dd731)
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b0cc4955d423858b7d75b1291a6d2d988b6a253

commit 6b0cc4955d423858b7d75b1291a6d2d988b6a253
Author: Marton Hunyady <hunyadym@chromium.org>
Date: Fri Jul 27 22:28:49 2018

Fix "Reboot and reset" button behavior for rollback

For enterprise rollback, the "Reboot and reset" button should just
reboot the device. Without this, the button behavior is broken (nothing
happens when pressing it), because we don't generally allow powerwash
for managed devices. The admin-initiated rollback is an exception to it.

Bug:  868263 
Change-Id: Iaa13429b35a52ef78d39e50ab42f17ac76a7eb33
Reviewed-on: https://chromium-review.googlesource.com/1152742
Commit-Queue: Marton Hunyady <hunyadym@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578832}
[modify] https://crrev.com/6b0cc4955d423858b7d75b1291a6d2d988b6a253/chrome/browser/resources/settings/about_page/about_page.js

Comment 2 by hunyadym@chromium.org, Jul 27

Labels: Merge-Request-69
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 28

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 30

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8347f5d674b693cd05cbbc1e5568c54ce5569475

commit 8347f5d674b693cd05cbbc1e5568c54ce5569475
Author: Marton Hunyady <hunyadym@chromium.org>
Date: Mon Jul 30 10:50:35 2018

Fix "Reboot and reset" button behavior for rollback

For enterprise rollback, the "Reboot and reset" button should just
reboot the device. Without this, the button behavior is broken (nothing
happens when pressing it), because we don't generally allow powerwash
for managed devices. The admin-initiated rollback is an exception to it.

Bug:  868263 
Change-Id: Iaa13429b35a52ef78d39e50ab42f17ac76a7eb33
Reviewed-on: https://chromium-review.googlesource.com/1152742
Commit-Queue: Marton Hunyady <hunyadym@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#578832}(cherry picked from commit 6b0cc4955d423858b7d75b1291a6d2d988b6a253)
Reviewed-on: https://chromium-review.googlesource.com/1154867
Reviewed-by: Marton Hunyady <hunyadym@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#203}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/8347f5d674b693cd05cbbc1e5568c54ce5569475/chrome/browser/resources/settings/about_page/about_page.js

Comment 5 by hunyadym@chromium.org, Jul 31

Status: Fixed (was: Started)

Comment 6 by vaandres@chromium.org, Aug 13

Status: Verified (was: Fixed)
Verified Reset and Reboot button works after triggering rollback on M70
►

Sign in to add a comment