MTPDeviceDelegateImplWinTest.GalleryNameMTP is failing on Win7 Tests (1) |
||||
Issue descriptionFirst failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%281%29/82128 Please take a look
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/141c80010e021e72dc57c73f383e74e299729331 commit 141c80010e021e72dc57c73f383e74e299729331 Author: Henrik Boström <hbos@chromium.org> Date: Fri Jul 27 09:23:59 2018 Disable failing test MTPDeviceDelegateImplWinTest.GalleryNameMTP. TBR=fdoray@chromium.org, reillyg@chromium.org NOTRY=True Bug: 868254 Change-Id: I5e80699e1d04e51be31a097b2b4deb0ec5e3a7ce Reviewed-on: https://chromium-review.googlesource.com/1152737 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#578576} [modify] https://crrev.com/141c80010e021e72dc57c73f383e74e299729331/chrome/browser/media_galleries/win/mtp_device_delegate_impl_win_unittest.cc
,
Jul 27
,
Jul 27
Issue 868281 has been merged into this issue.
,
Jul 27
,
Jul 27
Re-assigning to reillyg@. I'm not familiar with media galleries code.
,
Jul 27
The test passes locally on Win 10 here. The 4 expected galleries are:
%TEMP%\scope_dir_foo\{music0, pictures0, videos0} and a MTP device. For some reason the fake media dirs are mssing.
,
Jul 27
The _missing_ fake media dirs should have been created by EnsureMediaDirectoriesExists.
,
Jul 27
I have noticed that sometimes the EnsureMediaDirectoriesExists fails to actually make them. Most often on Windows. It's not guaranteed to work apparently. What I don't get is: Why doesn't this code catch that in its CHECK? https://cs.chromium.org/chromium/src/base/test/scoped_path_override.cc?sq=package:chromium&dr=CSs&g=0&l=32 |
||||
►
Sign in to add a comment |
||||
Comment 1 by hbos@chromium.org
, Jul 27