New issue
Advanced search Search tips

Issue 868253 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Flaky WorkerThreadTest.TerminateWorkerWhileChildIsLoading on several bots

Project Member Reported by machenb...@chromium.org, Jul 27

Issue description

Cc: hbos@chromium.org
+chrome sheriff
Other example:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests/71349

Maybe that test could get disabled?
Yes! I'm on it :) thanks
Cc: nhiroki@chromium.org
Owner: japhet@chromium.org
Status: Assigned (was: Untriaged)
japhet can you take a look?
Summary: Flaky WorkerThreadTest.TerminateWorkerWhileChildIsLoading on several bots (was: Flaky webkit_unit_tests on several bots)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2250e83f78dcfef67e31d14bb6da10e4b81ecd0

commit f2250e83f78dcfef67e31d14bb6da10e4b81ecd0
Author: Henrik Boström <hbos@chromium.org>
Date: Fri Jul 27 09:42:23 2018

Disable flaky WorkerThreadTest.TerminateWorkerWhileChildIsLoading.

It was added in this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1145872

I wasn't sure whether to revert that CL or disable the test. Disabling.

It's flakily not terminated:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8939871163610794448/+/steps/webkit_unit_tests_on_Windows-10-15063/0/logs/WorkerThreadTest.TerminateWorkerWhileChildIsLoading/0

TBR=japhet@chromium.org, nhiroki@chromium.org
NOTRY=True

Bug:  868253 
Change-Id: I286472514666b2d11627a515fdab92e0d73cd155
Reviewed-on: https://chromium-review.googlesource.com/1152743
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578577}
[modify] https://crrev.com/f2250e83f78dcfef67e31d14bb6da10e4b81ecd0/third_party/blink/renderer/core/workers/worker_thread_test.cc

Labels: -Sheriff-Chromium
Disabled, removing sheriff label.
Components: -Blink Blink>Workers
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ab59c9c446e1dff1db121e19e4ea0cc8e17a298

commit 5ab59c9c446e1dff1db121e19e4ea0cc8e17a298
Author: Nate Chapin <japhet@chromium.org>
Date: Mon Jul 30 18:39:25 2018

De-flake WorkerThreadTest.TerminateWorkerWhileChildIsLoading

Bug:  868253 
Change-Id: Ib79fe6b36e3bfb06bc44d050d154c1ad23cf1585
Reviewed-on: https://chromium-review.googlesource.com/1153469
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579099}
[modify] https://crrev.com/5ab59c9c446e1dff1db121e19e4ea0cc8e17a298/third_party/blink/renderer/core/workers/worker_thread_test.cc

Status: Fixed (was: Assigned)

Sign in to add a comment