New issue
Advanced search Search tips

Issue 868251 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression
Team-Security-UX



Sign in to add a comment

Regression: Unwanted separator line is seen in 'chrome://settings/content/flash'.

Reported by sanyam.g...@etouch.net, Jul 27

Issue description

Chrome Version: 70.0.3504.0 (Official Build) caaa08e92d8d9e71ab033d902165bb9859bb15f2-refs/branch-heads/3504@{#1}(32/64 bit)

OS: Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04) OS

Steps to reproduce:
(1) Launch Chrome, navigate to 'chrome://settings' and go to Content Settings('chrome://settings/content').
(2) Go to 'Flash'(chrome://settings/content/flash) and observe the separator line.

Actual Result: Unwanted separator line is seen in 'chrome://settings/content/flash'.
Expected Result: Unwanted separator line should not be seen in 'chrome://settings/content/flash'.

This is a regression issue, broken in 'M-69', and below is per-revision bisect-info:
Good Build:69.0.3494.0(Revision:575514)
Bad Build: 69.0.3495.0(Revision:575926)

You are probably looking for a change made after 575576 (known good), but no later than 575577 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/43df04fe7fe11a69605cfa669226ae74b91c41c2..cb2802bdf77878126f93612ca1ae463d34072aed

@rhalavati: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:Pardon me if it is an intended change but no separator line is seen on any other content settings(Cookies, Location, Camera...)

Kindly review the attached screen-cast for reference.

Thank you..!!

 
Actual_Result.mp4
929 KB View Download
Expected_Result.mp4
941 KB View Download
Image.png
23.8 KB View Download
Status: Started (was: Assigned)
Thank you for filing this. I'm on it.
Status: Available (was: Started)
Cc: rhalavati@chromium.org
Owner: hkamila@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/823a4544bd8192e49ba251c50cf4059d5d88b7c3

commit 823a4544bd8192e49ba251c50cf4059d5d88b7c3
Author: Kamila <hkamila@google.com>
Date: Thu Sep 20 10:05:39 2018

Removed the unwanted separator line

Removed the separator line in "chrome://settings/content/flash" that should not
be there: https://imgur.com/a/yLP1ITi


Bug:  868251 
Change-Id: I14a745ddca7ae7294444c1ae3f51fab42c723524
Reviewed-on: https://chromium-review.googlesource.com/1221263
Commit-Queue: Kamila Hasanbega <hkamila@google.com>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592745}
[modify] https://crrev.com/823a4544bd8192e49ba251c50cf4059d5d88b7c3/chrome/browser/resources/settings/privacy_page/privacy_page.html

Status: Fixed (was: Assigned)
Labels: TE-Verified-M71 TE-Verified-71.0.3558.0
Update:

Rechecked the above issue on Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14)  and Linux(14.04 LTS)  OS using latest canary build #71.0.3558.0 and issue is fixed. No separator line is seen in 'chrome://settings/content/flash'.Hence adding TE Verified Labels.

Please find attached screen-cast for reference.

Thank You..!!
Fixed_Behaviour.mp4
474 KB View Download

Sign in to add a comment