Set oom_score_adj of chrome processes directly |
|||||
Issue descriptionAfter the fix in http://crbug.com/850457 , Chrome can set oom_score_adj to Chrome processes directly. The advantage of set oom_score_adj to Chrome processes directly: 1. It should be faster than set via debugd 2. It's not necessary to set via debugd when ARC++ is disabled.
,
Jul 28
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f6c2c59656fb462932cf57262e8c1b2f9c3b46f commit 0f6c2c59656fb462932cf57262e8c1b2f9c3b46f Author: Kuo-Hsin Yang <vovoy@chromium.org> Date: Mon Jul 30 06:57:17 2018 Set oom_score_adj of chrome processes directly Setting oom_score_adj directly is faster and doesn't have to involve debugd when ARC++ is disabled. Bug: 868249 Change-Id: Ifeda6cd1d393c85f373928aafadd4ec3d3941a92 Reviewed-on: https://chromium-review.googlesource.com/1152751 Reviewed-by: Cheng-Yu Lee <cylee@chromium.org> Commit-Queue: Vovo Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#578987} [modify] https://crrev.com/0f6c2c59656fb462932cf57262e8c1b2f9c3b46f/chrome/browser/resource_coordinator/tab_manager_delegate_chromeos.cc
,
Jul 30
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e64d2d620942faf985763c6c25f27448c84cea9d commit e64d2d620942faf985763c6c25f27448c84cea9d Author: Vovo Yang <vovoy@chromium.org> Date: Mon Jul 30 18:15:48 2018 Revert "Set oom_score_adj of chrome processes directly" This reverts commit 0f6c2c59656fb462932cf57262e8c1b2f9c3b46f. Reason for revert: crash on OnFocusTabScoreAdjustmentTimeout Bug: 869037 Original change's description: > Set oom_score_adj of chrome processes directly > > Setting oom_score_adj directly is faster and doesn't have to involve > debugd when ARC++ is disabled. > > Bug: 868249 > Change-Id: Ifeda6cd1d393c85f373928aafadd4ec3d3941a92 > Reviewed-on: https://chromium-review.googlesource.com/1152751 > Reviewed-by: Cheng-Yu Lee <cylee@chromium.org> > Commit-Queue: Vovo Yang <vovoy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578987} TBR=cylee@chromium.org,vovoy@chromium.org Change-Id: Iafc37f22743479ba558fcc520bd24e7a30bcc693 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868249 Reviewed-on: https://chromium-review.googlesource.com/1155327 Reviewed-by: Jun Mukai <mukai@chromium.org> Commit-Queue: Vovo Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#579090} [modify] https://crrev.com/e64d2d620942faf985763c6c25f27448c84cea9d/chrome/browser/resource_coordinator/tab_manager_delegate_chromeos.cc
,
Aug 3
Previous CL has been reverted and mukai@ has closed the crash bug crbug/869037. I'm taking over the rest of work after discussing with vovoy@.
,
Aug 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/acd58b3ac64ab2e422a2c365bc995cb02ab23470 commit acd58b3ac64ab2e422a2c365bc995cb02ab23470 Author: Cheng-Yu Lee <cylee@chromium.org> Date: Sat Aug 11 05:32:37 2018 Setting oom_score_adj directly is faster and doesn't have to involve debugd when ARC++ is disabled. Bug: 868249 Change-Id: Ie99e4c4ac7738c369a9b54bf2621a2c16dc8bc1d Reviewed-on: https://chromium-review.googlesource.com/1168222 Reviewed-by: Cheng-Yu Lee <cylee@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Cheng-Yu Lee <cylee@chromium.org> Cr-Commit-Position: refs/heads/master@{#582431} [modify] https://crrev.com/acd58b3ac64ab2e422a2c365bc995cb02ab23470/base/process/memory_linux.cc [modify] https://crrev.com/acd58b3ac64ab2e422a2c365bc995cb02ab23470/base/threading/thread_restrictions.h [modify] https://crrev.com/acd58b3ac64ab2e422a2c365bc995cb02ab23470/chrome/browser/resource_coordinator/tab_manager_delegate_chromeos.cc
,
Aug 13
,
Aug 15
cylee@, thanks for your help. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kuscher@chromium.org
, Jul 27