Intersection observation can't use GeometryMapper when the frame is throttled |
||||||
Issue description.. because property trees may not be up to date. GeometryMapper was enabled for M69. Let's target merging the fix.
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed12183d9f3e5dc9b42f8805c80874013e4599d1 commit ed12183d9f3e5dc9b42f8805c80874013e4599d1 Author: Vladimir Levin <vmpstr@chromium.org> Date: Fri Jul 27 21:11:53 2018 Don't use geometry mapper if the target frame is throttled. In order to use geometry mapper, we need to ensure that the prepaint step of the lifecycle has run. However, if the target frame is throttled this is not the case. We don't want to force run it, because it causes compositing to run which has memory implications. Instead fall back to slow path in intersection geometry. Bug: 868230 R=chrishtr@chromium.org, pdr@chromium.org Change-Id: Icaef44dd3e399b12df77eb550eb5ae0fa43291b6 Reviewed-on: https://chromium-review.googlesource.com/1150876 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#578794} [modify] https://crrev.com/ed12183d9f3e5dc9b42f8805c80874013e4599d1/third_party/blink/renderer/core/layout/intersection_geometry.cc [modify] https://crrev.com/ed12183d9f3e5dc9b42f8805c80874013e4599d1/third_party/blink/renderer/core/layout/layout_object.h
,
Jul 27
Going to wait a couple of days to make sure canary is fine with the change before requesting a merge.
,
Jul 31
The NextAction date has arrived: 2018-07-31
,
Aug 1
,
Aug 2
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 2
Pls merge your change to M69 branch 3497 ASAP. Thank you.
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2aeb90467699f2502b9392608623853a87bc1be commit c2aeb90467699f2502b9392608623853a87bc1be Author: Vladimir Levin <vmpstr@chromium.org> Date: Thu Aug 02 22:03:36 2018 Don't use geometry mapper if the target frame is throttled. In order to use geometry mapper, we need to ensure that the prepaint step of the lifecycle has run. However, if the target frame is throttled this is not the case. We don't want to force run it, because it causes compositing to run which has memory implications. Instead fall back to slow path in intersection geometry. Bug: 868230 R=chrishtr@chromium.org, pdr@chromium.org TBR=vmpstr@chromium.org (cherry picked from commit ed12183d9f3e5dc9b42f8805c80874013e4599d1) Change-Id: Icaef44dd3e399b12df77eb550eb5ae0fa43291b6 Reviewed-on: https://chromium-review.googlesource.com/1150876 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578794} Reviewed-on: https://chromium-review.googlesource.com/1161339 Reviewed-by: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#356} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/c2aeb90467699f2502b9392608623853a87bc1be/third_party/blink/renderer/core/layout/intersection_geometry.cc [modify] https://crrev.com/c2aeb90467699f2502b9392608623853a87bc1be/third_party/blink/renderer/core/layout/layout_object.h
,
Aug 3
,
Sep 4
FYI, the DCHECK added here is implicated in a different issue; please see bug 880388 . |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by chrishtr@chromium.org
, Jul 27