Add automated tests for launching Crostini apps from the File Manager and installing .deb files |
||||||
Issue descriptionBug 822513 and Bug 822464 added functionality in the File Manager to launch Crostini apps and install .deb files respectively. These need some tests!
,
Jul 31
Requesting a merge to 69 for the above CL. There's a one character typo fix for I think a crash or maybe UAF, the rest of the CL is adding tests.
,
Aug 1
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2837e5635ef0799879d1c2ccc5b5a64c7ca60b4b commit 2837e5635ef0799879d1c2ccc5b5a64c7ca60b4b Author: Timothy Loh <timloh@chromium.org> Date: Wed Aug 01 04:06:10 2018 [merge to 69] Add tests for InstallLinuxPackageDialog This CL adds some tests for the linux package install flow in the File Manager. It also fixes a bug in the CrostiniManager where package progress observers were not correctly removed, as discovered by these tests. Bug: 868221 Change-Id: I2b6adf2530ff43a0b22fe2b552bb877f98fd61c7 Reviewed-on: https://chromium-review.googlesource.com/1152643 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578975}(cherry picked from commit b4e92b237ed276982f0518387280d6df9d79fb4a) Reviewed-on: https://chromium-review.googlesource.com/1157964 Reviewed-by: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#305} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/2837e5635ef0799879d1c2ccc5b5a64c7ca60b4b/chrome/browser/chromeos/crostini/crostini_manager.cc [modify] https://crrev.com/2837e5635ef0799879d1c2ccc5b5a64c7ca60b4b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [add] https://crrev.com/2837e5635ef0799879d1c2ccc5b5a64c7ca60b4b/chrome/test/data/chromeos/file_manager/package.deb [modify] https://crrev.com/2837e5635ef0799879d1c2ccc5b5a64c7ca60b4b/ui/file_manager/file_manager/foreground/js/file_tasks_unittest.js [add] https://crrev.com/2837e5635ef0799879d1c2ccc5b5a64c7ca60b4b/ui/file_manager/integration_tests/file_manager/install_linux_package_dialog.js [modify] https://crrev.com/2837e5635ef0799879d1c2ccc5b5a64c7ca60b4b/ui/file_manager/integration_tests/file_manager_test_manifest.json [modify] https://crrev.com/2837e5635ef0799879d1c2ccc5b5a64c7ca60b4b/ui/file_manager/integration_tests/test_util.js
,
Oct 1
,
Oct 8
timloh@ Please provide verification steps. Thanks! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jul 30