New issue
Advanced search Search tips

Issue 868202 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 1
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-08-20
OS: ----
Pri: 1
Type: Task


Sign in to add a comment

Master: Migrate tryserver.blink builders to luci

Project Member Reported by efoo@chromium.org, Jul 27

Issue description

This is the master bug to migrate tryserver.blink builders to LUCI

Scheduled for week 2018-07-30
Client owner contact: dpranke@chromium.org
Obtain approvals from dpranke/jbudorick


 
Description: Show this description
Cc: efoo@chromium.org
The NextAction date has arrived: 2018-07-30
NextAction: 2018-08-03
Marking next action date to EOW for follow up. 
The NextAction date has arrived: 2018-08-03
NextAction: 2018-08-20
Delayed. Updated next action to 08/20/2018
The NextAction date has arrived: 2018-08-20
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85743ab9055376536709f6e90a5faa1d0858713f

commit 85743ab9055376536709f6e90a5faa1d0858713f
Author: Ryan Tseng <hinoka@google.com>
Date: Thu Sep 13 19:44:17 2018

Add tryserver.blink builders

Also: Removed the luci-check comments, since it's no longer used.

Bug:  868202 
Change-Id: If971e2c2a9ed5b445ccd7eaa9f34e57be1f75191
Reviewed-on: https://chromium-review.googlesource.com/1224798
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591116}
[modify] https://crrev.com/85743ab9055376536709f6e90a5faa1d0858713f/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/85743ab9055376536709f6e90a5faa1d0858713f/infra/config/global/luci-milo.cfg

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/b46e34ee783d00ab184d9fe4200e2afb3503084a

commit b46e34ee783d00ab184d9fe4200e2afb3503084a
Author: Ryan Tseng <hinoka@google.com>
Date: Fri Sep 14 21:31:12 2018

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 15

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/d632fc9bb54800c50f14c19de804221cb360e1f1

commit d632fc9bb54800c50f14c19de804221cb360e1f1
Author: Ryan Tseng <hinoka@google.com>
Date: Sat Sep 15 00:29:13 2018

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05ba520bee0c565bc0d7d9313d1c43790c1b6627

commit 05ba520bee0c565bc0d7d9313d1c43790c1b6627
Author: Ryan Tseng <hinoka@google.com>
Date: Mon Sep 17 20:13:39 2018

luci-milo.cfg: Fix tryserver.blink luci configs

Bug:  868202 
Change-Id: I972c059b3ccd2c8e8c03635b8c8471673c902a07
Reviewed-on: https://chromium-review.googlesource.com/1228128
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591799}
[modify] https://crrev.com/05ba520bee0c565bc0d7d9313d1c43790c1b6627/infra/config/global/luci-milo.cfg

Owner: efoo@chromium.org
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/7da982abf99f9feced310f51a9fc058c4ed7baaf

commit 7da982abf99f9feced310f51a9fc058c4ed7baaf
Author: Eric Foo <efoo@chromium.org>
Date: Mon Nov 19 23:58:00 2018

Update to use new LUCI builders

Bug:868202
Change-Id: Ic480356aa4b385e97eb3e47a6f1a439aeb82720a
Reviewed-on: https://chromium-review.googlesource.com/c/1341227
Commit-Queue: Eric Foo <efoo@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/7da982abf99f9feced310f51a9fc058c4ed7baaf/tests/presubmit_unittest.py

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2f88692e98ce7233d2df7c724465ecacfe74df5

commit c2f88692e98ce7233d2df7c724465ecacfe74df5
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Nov 20 01:23:00 2018

Roll src/third_party/depot_tools ae6836ecee57..7da982abf99f (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ae6836ecee57..7da982abf99f


git log ae6836ecee57..7da982abf99f --date=short --no-merges --format='%ad %ae %s'
2018-11-19 efoo@chromium.org Update to use new LUCI builders


Created with:
  gclient setdep -r src/third_party/depot_tools@7da982abf99f

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:868202 
TBR=agable@chromium.org

Change-Id: Ibf7a764150fdd25102bd318d37727901ffdceadc
Reviewed-on: https://chromium-review.googlesource.com/c/1343183
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609545}
[modify] https://crrev.com/c2f88692e98ce7233d2df7c724465ecacfe74df5/DEPS

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d53bc243c90d760f4013cb44a735769a16ac914

commit 7d53bc243c90d760f4013cb44a735769a16ac914
Author: Eric Foo <efoo@chromium.org>
Date: Tue Nov 20 02:02:20 2018

Remove incorrect named builders ("_" underscores)

Bug:  868202 
Change-Id: I807807511df39b7a4eac3b699fcd2274d4d24138
Reviewed-on: https://chromium-review.googlesource.com/c/1343081
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609559}
[modify] https://crrev.com/7d53bc243c90d760f4013cb44a735769a16ac914/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/7d53bc243c90d760f4013cb44a735769a16ac914/infra/config/global/luci-milo.cfg
[modify] https://crrev.com/7d53bc243c90d760f4013cb44a735769a16ac914/tools/mb/mb_config.pyl

With the CL in c#15, linux_trusty_blink_rel is now failing the 'analyze' step [1], so I take "things have been updated" doesn't quite hold true there - or? It's still referenced in infra/config/branch/cq.cfg (added by 567a2828a5035526b3192507dc20a0b09afe91bd).

[1] https://ci.chromium.org/buildbot/tryserver.blink/linux_trusty_blink_rel/
Project Member

Comment 17 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa4a0042e682cc19b293f5bf74cbc9ab24cd5137

commit aa4a0042e682cc19b293f5bf74cbc9ab24cd5137
Author: John Budorick <jbudorick@chromium.org>
Date: Tue Nov 20 21:59:12 2018

Revert "Remove incorrect named builders ("_" underscores)"

This reverts commit 7d53bc243c90d760f4013cb44a735769a16ac914.

Reason for revert: still referenced by cq.cfg.

Original change's description:
> Remove incorrect named builders ("_" underscores)
> 
> Bug:  868202 
> Change-Id: I807807511df39b7a4eac3b699fcd2274d4d24138
> Reviewed-on: https://chromium-review.googlesource.com/c/1343081
> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: Eric Foo <efoo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609559}

TBR=hinoka@chromium.org,efoo@chromium.org,jbudorick@chromium.org

Change-Id: Ic530f835ef9367cda18f54be54dc712d3f229ded
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  868202 
Reviewed-on: https://chromium-review.googlesource.com/c/1345234
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609816}
[modify] https://crrev.com/aa4a0042e682cc19b293f5bf74cbc9ab24cd5137/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/aa4a0042e682cc19b293f5bf74cbc9ab24cd5137/infra/config/global/luci-milo.cfg
[modify] https://crrev.com/aa4a0042e682cc19b293f5bf74cbc9ab24cd5137/tools/mb/mb_config.pyl

Project Member

Comment 19 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/8b4ff0d7ccb692014f0b8a177e86659246d165d5

commit 8b4ff0d7ccb692014f0b8a177e86659246d165d5
Author: Sergiy Byelozyorov <sergiyb@chromium.org>
Date: Wed Nov 21 13:03:05 2018

[tools] Update builder name as old builder is deprecated

R=efoo@chromium.org, machenbach@chromium.org

Bug:  chromium:868202 
Change-Id: I5c0860894c96a8ce14e74cb048f786908db88269
Reviewed-on: https://chromium-review.googlesource.com/c/1344150
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57680}
[modify] https://crrev.com/8b4ff0d7ccb692014f0b8a177e86659246d165d5/tools/release/auto_roll.py
[modify] https://crrev.com/8b4ff0d7ccb692014f0b8a177e86659246d165d5/tools/release/test_scripts.py

Project Member

Comment 20 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/bf6b6fe6c9695838bb22670fd0793caf84ac7573

commit bf6b6fe6c9695838bb22670fd0793caf84ac7573
Author: Sergiy Belozorov <sergiyb@chromium.org>
Date: Mon Nov 26 16:52:36 2018

[tools] Rename master.tryserver.blink:linux_trusty_blink_rel to luci.chromium.try:linux-blink-rel

TBR=machenbach@chromium.org

No-Try: true
No-Tree-Checks: true
Bug:  chromium:868202 
Change-Id: I0cfbd995d83733b30e58246b2faccc51379957a6
Reviewed-on: https://chromium-review.googlesource.com/c/1351017
Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org>
Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57846}
[modify] https://crrev.com/bf6b6fe6c9695838bb22670fd0793caf84ac7573/infra/config/cq.cfg

Project Member

Comment 21 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/f918f5e1415e69524e79a232cc59f2c478a891be

commit f918f5e1415e69524e79a232cc59f2c478a891be
Author: Eric Foo <efoo@chromium.org>
Date: Thu Nov 29 02:20:39 2018

Remove tryserver.blink master

Bug:868202
Change-Id: I1243d51b7b8e95627181bac5241bde827c8d3d55
Reviewed-on: https://chromium-review.googlesource.com/c/1341129
Commit-Queue: Eric Foo <efoo@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

[delete] https://crrev.com/2001305899a3f87fc4a5cfc051b6d78e78a4c665/masters/master.tryserver.blink/slaves.cfg
[delete] https://crrev.com/2001305899a3f87fc4a5cfc051b6d78e78a4c665/masters/master.tryserver.blink/public_html/default.css
[delete] https://crrev.com/2001305899a3f87fc4a5cfc051b6d78e78a4c665/masters/master.tryserver.blink/master.cfg
[modify] https://crrev.com/f918f5e1415e69524e79a232cc59f2c478a891be/tests/masters_recipes_test.py
[delete] https://crrev.com/2001305899a3f87fc4a5cfc051b6d78e78a4c665/masters/master.tryserver.blink/public_html/buildbot.css
[modify] https://crrev.com/f918f5e1415e69524e79a232cc59f2c478a891be/tests/masters_test.py
[delete] https://crrev.com/2001305899a3f87fc4a5cfc051b6d78e78a4c665/masters/master.tryserver.blink/templates/builder_stats.html
[delete] https://crrev.com/2001305899a3f87fc4a5cfc051b6d78e78a4c665/masters/master.tryserver.blink/public_html/common-resources
[delete] https://crrev.com/2001305899a3f87fc4a5cfc051b6d78e78a4c665/masters/master.tryserver.blink/templates/builder.html
[delete] https://crrev.com/2001305899a3f87fc4a5cfc051b6d78e78a4c665/masters/master.tryserver.blink/public_html/favicon.ico
[delete] https://crrev.com/2001305899a3f87fc4a5cfc051b6d78e78a4c665/masters/master.tryserver.blink/Makefile
[delete] https://crrev.com/2001305899a3f87fc4a5cfc051b6d78e78a4c665/masters/master.tryserver.blink/templates/build.html
[delete] https://crrev.com/2001305899a3f87fc4a5cfc051b6d78e78a4c665/masters/master.tryserver.blink/public_html/chromium-32.png
[delete] https://crrev.com/2001305899a3f87fc4a5cfc051b6d78e78a4c665/masters/master.tryserver.blink/public_html/robots.txt
[delete] https://crrev.com/2001305899a3f87fc4a5cfc051b6d78e78a4c665/masters/master.tryserver.blink/master_site_config.py
[delete] https://crrev.com/2001305899a3f87fc4a5cfc051b6d78e78a4c665/masters/master.tryserver.blink/templates/stats.html
[delete] https://crrev.com/2001305899a3f87fc4a5cfc051b6d78e78a4c665/masters/master.tryserver.blink/public_html/bg_gradient.jpg

Project Member

Comment 22 by bugdroid1@chromium.org, Dec 1

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/f07f05bb0b5543e32b6a7984e27a5279cdd15ea3

commit f07f05bb0b5543e32b6a7984e27a5279cdd15ea3
Author: Eric Foo <efoo@google.com>
Date: Sat Dec 01 01:56:56 2018

Status: Fixed (was: Assigned)
"-" builders have been migrated to LUCI. All remaining Buildbot builders have been shutdown. References to linux_trusty_blink_rel have been updated to use new linux-blink-rel builder. 

Marking as fixed. 
Project Member

Comment 24 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ae897670d16d6696403b00a9473e7c86de17dd3

commit 7ae897670d16d6696403b00a9473e7c86de17dd3
Author: Eric Foo <efoo@chromium.org>
Date: Mon Dec 03 21:25:38 2018

Reland "Remove incorrect named builders ("_" underscores)"

This is a reland of 7d53bc243c90d760f4013cb44a735769a16ac914

Original change's description:
> Remove incorrect named builders ("_" underscores)
> 
> Bug:  868202 
> Change-Id: I807807511df39b7a4eac3b699fcd2274d4d24138
> Reviewed-on: https://chromium-review.googlesource.com/c/1343081
> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: Eric Foo <efoo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609559}

Bug:  868202 
Change-Id: I26a75c2226e910637c677b28598865ad31fb67e2
Reviewed-on: https://chromium-review.googlesource.com/c/1357720
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613251}
[modify] https://crrev.com/7ae897670d16d6696403b00a9473e7c86de17dd3/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/7ae897670d16d6696403b00a9473e7c86de17dd3/infra/config/global/luci-milo.cfg
[modify] https://crrev.com/7ae897670d16d6696403b00a9473e7c86de17dd3/tools/mb/mb_config.pyl

Sign in to add a comment