New issue
Advanced search Search tips

Issue 868192 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue 877952

Blocking:
issue 852089
issue 877133



Sign in to add a comment

Implement a WebGPU command decoder

Project Member Reported by kainino@chromium.org, Jul 27

Issue description

I have been working on this, but I should associate it with a real bug id.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/328e07a0ecdf7486279f30393051e47c945b3730

commit 328e07a0ecdf7486279f30393051e47c945b3730
Author: Kai Ninomiya <kainino@chromium.org>
Date: Thu Aug 23 01:08:16 2018

Add GpuPreferences entry for enable_webgpu

Doing this requires moving --enable-unsafe-webgpu
from content_switches to gpu_switches.

Bug:  868192 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I757bd228248b8cf733c381217fbb00e69e2482c0
Reviewed-on: https://chromium-review.googlesource.com/1184264
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585349}
[modify] https://crrev.com/328e07a0ecdf7486279f30393051e47c945b3730/content/child/runtime_features.cc
[modify] https://crrev.com/328e07a0ecdf7486279f30393051e47c945b3730/content/public/common/content_switches.cc
[modify] https://crrev.com/328e07a0ecdf7486279f30393051e47c945b3730/content/public/common/content_switches.h
[modify] https://crrev.com/328e07a0ecdf7486279f30393051e47c945b3730/gpu/command_buffer/service/service_utils.cc
[modify] https://crrev.com/328e07a0ecdf7486279f30393051e47c945b3730/gpu/config/gpu_preferences.h
[modify] https://crrev.com/328e07a0ecdf7486279f30393051e47c945b3730/gpu/config/gpu_preferences_unittest.cc
[modify] https://crrev.com/328e07a0ecdf7486279f30393051e47c945b3730/gpu/config/gpu_switches.cc
[modify] https://crrev.com/328e07a0ecdf7486279f30393051e47c945b3730/gpu/config/gpu_switches.h
[modify] https://crrev.com/328e07a0ecdf7486279f30393051e47c945b3730/gpu/ipc/common/gpu_preferences.mojom
[modify] https://crrev.com/328e07a0ecdf7486279f30393051e47c945b3730/gpu/ipc/common/gpu_preferences_struct_traits.h

Blocking: 877133
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccab4bc38337ec3306b5f3847f7f88b358111309

commit ccab4bc38337ec3306b5f3847f7f88b358111309
Author: Kai Ninomiya <kainino@chromium.org>
Date: Fri Aug 24 08:43:40 2018

Add a WebGPU command decoder

This is a almost entirely a copy of the necessary parts of the
Raster command decoder.

Implements one dummy command (called Dummy) which will be replaced
by real commands.

Bug:  868192 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iccc1274fb251896b404573de4738b5b37b16b316
Reviewed-on: https://chromium-review.googlesource.com/1147251
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585762}
[modify] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/content/renderer/BUILD.gn
[modify] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/BUILD.gn
[modify] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/build_cmd_buffer_lib.py
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/build_webgpu_cmd_buffer.py
[modify] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/client/BUILD.gn
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/client/webgpu_cmd_helper.cc
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/client/webgpu_cmd_helper.h
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/client/webgpu_cmd_helper_autogen.h
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/client/webgpu_export.h
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/client/webgpu_implementation.cc
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/client/webgpu_implementation.h
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/client/webgpu_implementation_autogen.h
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/client/webgpu_implementation_impl_autogen.h
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/client/webgpu_implementation_unittest.cc
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/client/webgpu_implementation_unittest_autogen.h
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/client/webgpu_interface.h
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/client/webgpu_interface_autogen.h
[modify] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/common/BUILD.gn
[modify] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/common/context_creation_attribs.cc
[modify] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/common/context_creation_attribs.h
[modify] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/common/raster_cmd_format.h
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/common/webgpu_cmd_format.cc
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/common/webgpu_cmd_format.h
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/common/webgpu_cmd_format_autogen.h
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/common/webgpu_cmd_format_test.cc
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/common/webgpu_cmd_format_test_autogen.h
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/common/webgpu_cmd_ids.h
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/common/webgpu_cmd_ids_autogen.h
[modify] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/service/BUILD.gn
[modify] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/service/feature_info.h
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/service/webgpu_cmd_validation.cc
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/service/webgpu_cmd_validation.h
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/service/webgpu_cmd_validation_autogen.h
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/service/webgpu_cmd_validation_implementation_autogen.h
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/service/webgpu_decoder.cc
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/service/webgpu_decoder.h
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/service/webgpu_decoder_unittest.cc
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/command_buffer/webgpu_cmd_buffer_functions.txt
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/ipc/client/webgpu_in_process_context_tests.cc
[modify] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/ipc/in_process_command_buffer.cc
[modify] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/ipc/service/command_buffer_stub.cc
[modify] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/ipc/service/gpu_channel.cc
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/ipc/service/webgpu_command_buffer_stub.cc
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/ipc/service/webgpu_command_buffer_stub.h
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/ipc/webgpu_in_process_context.cc
[add] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/gpu/ipc/webgpu_in_process_context.h
[modify] https://crrev.com/ccab4bc38337ec3306b5f3847f7f88b358111309/services/ui/public/cpp/gpu/BUILD.gn

Blockedon: 877952
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47630727fce35fe6f8afee7b0a58ee6172a52950

commit 47630727fce35fe6f8afee7b0a58ee6172a52950
Author: Kai Ninomiya <kainino@chromium.org>
Date: Tue Aug 28 18:02:10 2018

Command buffer changes needed for WebGPU in Blink

A few more changes, following up to the previous commit which added the WebGPU command buffer.

Bug:  868192 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iade27669c2bdebb598463b579a8dfaa6b91fbb9b
Reviewed-on: https://chromium-review.googlesource.com/1192411
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586784}
[modify] https://crrev.com/47630727fce35fe6f8afee7b0a58ee6172a52950/gpu/command_buffer/build_webgpu_cmd_buffer.py
[modify] https://crrev.com/47630727fce35fe6f8afee7b0a58ee6172a52950/gpu/command_buffer/client/webgpu_implementation.cc
[modify] https://crrev.com/47630727fce35fe6f8afee7b0a58ee6172a52950/gpu/command_buffer/client/webgpu_implementation_impl_autogen.h
[modify] https://crrev.com/47630727fce35fe6f8afee7b0a58ee6172a52950/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/47630727fce35fe6f8afee7b0a58ee6172a52950/gpu/command_buffer/service/feature_info.h
[modify] https://crrev.com/47630727fce35fe6f8afee7b0a58ee6172a52950/gpu/command_buffer/service/webgpu_decoder.cc

Status: Fixed (was: Started)

Sign in to add a comment