Reproduces with ChromeVox with search + a then w. ChromeVox reads the title of the underlying page instead of the Print dialog. It also doesn't say the print dialog when looking for the description of the current location.


Google Chrome	69.0.3497.35 (Official Build) dev (64-bit)
Firmware Version	Google_Lulu.6301.136.57

 Issue 868616  has been merged into this issue.

See  issue 775680 . The print dialog is also a tab-modal dialog, but there might be additional work necessary to fix this bug, since it's a WebDialogDelegate, which doesn't set an accessible title. Other dialogs likely to also be broken:
# CertificateViewerModalDialog
# MediaRouterDialogDelegate
# SigninEmailConfirmationDialog

I can't find any of these on Windows. Leo or Laura, could you check if the certificate viewer on Chrome OS (the lock/"secure" button in the omnibox should open up a menu with a "Certificate" item)?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45d4385b66f44ec577b89c1497723d6a7d7d1616

commit 45d4385b66f44ec577b89c1497723d6a7d7d1616
Author: James Wallace-Lee <jamwalla@chromium.org>
Date: Fri Aug 31 21:19:46 2018

Add accessible title to WebDialogDelegates

WebDialogDelegate should mirror DialogDelegate and provide an
implementation of WidgetDelegate::GetAccessibleWindowTitle. This also
adds an accessible title to the Print dialog.

Bug: 868179
Change-Id: I8e1c4b7262130b1a68f861bae9822ee191b0a06c
Reviewed-on: https://chromium-review.googlesource.com/1187623
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588171}
[modify] https://crrev.com/45d4385b66f44ec577b89c1497723d6a7d7d1616/chrome/browser/printing/print_preview_dialog_controller.cc
[modify] https://crrev.com/45d4385b66f44ec577b89c1497723d6a7d7d1616/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc
[modify] https://crrev.com/45d4385b66f44ec577b89c1497723d6a7d7d1616/ui/views/controls/webview/web_dialog_view.cc
[modify] https://crrev.com/45d4385b66f44ec577b89c1497723d6a7d7d1616/ui/views/controls/webview/web_dialog_view.h
[modify] https://crrev.com/45d4385b66f44ec577b89c1497723d6a7d7d1616/ui/web_dialogs/web_dialog_delegate.cc
[modify] https://crrev.com/45d4385b66f44ec577b89c1497723d6a7d7d1616/ui/web_dialogs/web_dialog_delegate.h

+a11y-testers for verification, thanks!

Google Chrome	71.0.3554.0 (Official Build) dev (64-bit)
Firmware Version	Google_Caroline.7820.384.0

Not working on Chrome OS. I enable ChromeVox, use ctrl + p on this page, then invoke the title command by going to the ChromeVox menu (search + period) then navigating to read title of page. It still reads the title of the underlying page instead of the print dialog. 

Removing a11y-testers label, please put back on when you'd like us to verify again. 

I wasn't able to finish this up, marking as Available for now. (Since the windows portion is fixed, I'm also updating this as a CrOS only bug).

I suspect r588171 did route the title announcement to the title of the print dialog. The issue is the print dialog has the same title as the underlying page.

So what exactly do we actually want to announce for the title of the print dialog? If the underlying page has the title of "Foo Bar", do we announce: Print: Foo Bar? Print Preview: Foo Bar? Print? Print Preview?

The title is not actually visible in the UI anywhere. It is only being set since the print preview dialog shows up in the task manager.