New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 868173 link

Starred by 1 user
Status: Verified
Owner:
█ jrbarnette@chromium.org
Last visit > 30 days ago
Closed: Jul 30
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Log host info during repair and verify

Reported by jrbarnette@chromium.org, Jul 27 
Recently, there was a exercise studying manual repair processes, looking
for (among other things) opportunities for improvement:
    https://docs.google.com/document/d/17mBuV75XgkUuDlTxPSYUyl0X88PkSI-JJymtr_aZF3E/edit#

One item identified was that it would be helpful for certain information
always to be available in repair logs, including:
  * DUT hostname
  * DUT board
  * DUT model
  * Servo beaglebone/labstation hostname
  * Servo port number

The information can easily be included in the status.log by recording an
"INFO" line at the start of each call to repair().

Comment 1 by jrbarnette@chromium.org, Jul 27 

A fix is pending.  The attached log files show samples of what
verify (provision-status.log) and repair (repair-status.log) will
look like in practice.
provision-status.log
2.9 KB View Download
repair-status.log
2.4 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/abbdc25929a815b1c556d2afe63bb36a4e5d8c89

commit abbdc25929a815b1c556d2afe63bb36a4e5d8c89
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Sat Jul 28 02:10:59 2018

[autotest] At the start of repair, log extra INFO

This adds an extra INFO line to status.log for repair and verify
operations to ensure that basic information about the DUT and its
servo is always recorded.

BUG= chromium:868173 
TEST=run repair in a local instance

Change-Id: Ic991820d02910f62436a8bf8786f11b6ebb9b868
Reviewed-on: https://chromium-review.googlesource.com/1152501
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Alex Zamorzaev <zamorzaev@chromium.org>

[modify] https://crrev.com/abbdc25929a815b1c556d2afe63bb36a4e5d8c89/server/hosts/cros_host.py
[modify] https://crrev.com/abbdc25929a815b1c556d2afe63bb36a4e5d8c89/server/hosts/servo_host.py

Comment 3 by jrbarnette@chromium.org, Jul 30

Status: Fixed (was: Started)
Now waiting for push to prod.
►

Sign in to add a comment