New issue
Advanced search Search tips

Issue 868166 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

crash-reporter: remove need for crash_sender.pid

Project Member Reported by vapier@chromium.org, Jul 26

Issue description

autotest/files/client/cros/crash/crash_test.py has logic to read crash_sender.pid so it can forcibly kill any instances of crash_sender that are running on the system.  that shouldn't be necessary at all as autotest should be able to just do `killall crash_sender` (or whatever equiv autotest might already have).

once autotest stops relying on that file, we can stop creating it in crash_sender.
 
Owner: vapier@chromium.org
Status: Started (was: Available)
autotest cleanup landed here:
  https://chromium-review.googlesource.com/1154356
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ae8c010fa63f7d4ba1fab53ebc1a67ad7050104d

commit ae8c010fa63f7d4ba1fab53ebc1a67ad7050104d
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Aug 15 11:42:48 2018

crash: drop crash_sender.pid creation

Now that the autotest no longer uses it, we can stop creating it.

BUG=chromium:391887, chromium:868166 
TEST=precq passes

Change-Id: I9b28efa483af9392cfbbdfa9e66535e347f1c383
Reviewed-on: https://chromium-review.googlesource.com/1168261
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Satoru Takabayashi <satorux@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/ae8c010fa63f7d4ba1fab53ebc1a67ad7050104d/crash-reporter/crash_sender.cc
[modify] https://crrev.com/ae8c010fa63f7d4ba1fab53ebc1a67ad7050104d/crash-reporter/crash_sender_paths.h

Components: -Internals>CrashReporting OS>Systems>CrashReporting
Status: Fixed (was: Started)

Sign in to add a comment