Issue metadata
Sign in to add a comment
|
Crash Report - translate::TranslateInfoBarDelegate::Create |
||||||||||||||||||||||
Issue descriptionPlease take a look at the bug below. This crash caused chrome for iOS to pause stable rollout for M68. Mahmadi@ provided a band-aid fix for M68 but we need a true fix to be merged into M69. https://bugs.chromium.org/p/chromium/issues/detail?id=867097&can=2&start=0&num=100&q=owner%3Ame&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified&groupby=&sort=&hotlist_id=
,
Jul 30
The existing fix may be good enough. This will simply skip the "never translate" infobar if the tab has been closed in the meantime. Seems very reasonable to me. Another approach would be to show the "never translate" infobar in the current active tab in that case, but that would seem odd.
,
Jul 30
Hi droger@ - thank you for your quick response. If we did not have mahmadi@'s fix, what would be your solution?
,
Aug 1
droger: I want to make sure the long-term fix for this is the right fix and not just "good enough." Please let me know.
,
Aug 2
I think this is a good fix. I don't have a clue why this started happening in M69. I am not aware of changes that could be causing this. From what I can tell, the fix should not introduce any new crash: the delegate is owned by the infobar, and thus calling infobar() is safe here.
,
Aug 2
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by monor...@bugs.chromium.org
, Jul 30