Issue metadata
Sign in to add a comment
|
7.1%-11.6% regression in loading.desktop at 578242:578254 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jul 26
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14d1dc0fa40000
,
Jul 26
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14d1dc0fa40000 [LayoutNG] Batch computing glyph bounds for ShapeResult by kojii@chromium.org https://chromium.googlesource.com/chromium/src/+/342e3c40354fd928391a96eab740d145a7d23e75 108 → 118.6 (+10.59) Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Jul 27
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/11a873fda40000
,
Jul 27
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/11a873fda40000 Avoid batch preparation for SkPaint::getTextWidth on Mac by kojii@chromium.org https://chromium-review.googlesource.com/c/chromium/src/+/1153007/2 117.4 → 109.3 (-8.112) Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Jul 27
,
Jul 27
Issue 868357 has been merged into this issue.
,
Jul 27
Issue 868354 has been merged into this issue.
,
Jul 27
Issue 868355 has been merged into this issue.
,
Jul 27
,
Jul 27
Issue 868435 has been merged into this issue.
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a643a1efdc29d270b3be8f46adc973514e3d60a commit 5a643a1efdc29d270b3be8f46adc973514e3d60a Author: Koji Ishii <kojii@chromium.org> Date: Fri Jul 27 18:18:29 2018 Avoid batch preparation for SkPaint::getTextWidth on Mac This patch stops batching SkPaint::getTextWidth() on Mac. Batching SkPaint::getTextWidth() http://crrev.com/c/1150010 has no benefits on Mac because Mac uses getTextPath() instead of getTextWidth() due to https://bugs.chromium.org/p/skia/issues/detail?id=5328 The cost to prepare batching is usually much lower than the benefit of batching, the total speed is more than 10x faster, but since Mac does not get the benefit at all, the cost of the preparation turned out to be not ignorable. http://crrev.com/c/1150010: https://pinpoint-dot-chromeperf.appspot.com/job/14d1dc0fa40000 This CL: https://pinpoint-dot-chromeperf.appspot.com/job/11a873fda40000 Bug: 868148 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ifbb0f6576cd58f36cd17463a550a15924f5b2209 Reviewed-on: https://chromium-review.googlesource.com/1153007 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#578711} [modify] https://crrev.com/5a643a1efdc29d270b3be8f46adc973514e3d60a/third_party/blink/renderer/platform/fonts/shaping/shape_result.cc
,
Jul 27
,
Jul 27
,
Jul 27
,
Jul 27
,
Jul 28
Issue 868518 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jul 26