New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 868148 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

7.1%-11.6% regression in loading.desktop at 578242:578254

Project Member Reported by ushesh@chromium.org, Jul 26

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=868148

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=b54fd6afea9c9336db164b6cf40c08db111e5794fa43642912cae843f6f35622


Bot(s) for this bug's original alert(s):

mac-10_13_laptop_high_end-perf
Cc: kojii@chromium.org
Owner: kojii@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14d1dc0fa40000

[LayoutNG] Batch computing glyph bounds for ShapeResult by kojii@chromium.org
https://chromium.googlesource.com/chromium/src/+/342e3c40354fd928391a96eab740d145a7d23e75
108 → 118.6 (+10.59)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/11a873fda40000

Avoid batch preparation for SkPaint::getTextWidth on Mac by kojii@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/1153007/2
117.4 → 109.3 (-8.112)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Cc: pmeenan@chromium.org
 Issue 868358  has been merged into this issue.
 Issue 868357  has been merged into this issue.
 Issue 868354  has been merged into this issue.
 Issue 868355  has been merged into this issue.
Status: Started (was: Assigned)
 Issue 868435  has been merged into this issue.
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a643a1efdc29d270b3be8f46adc973514e3d60a

commit 5a643a1efdc29d270b3be8f46adc973514e3d60a
Author: Koji Ishii <kojii@chromium.org>
Date: Fri Jul 27 18:18:29 2018

Avoid batch preparation for SkPaint::getTextWidth on Mac

This patch stops batching SkPaint::getTextWidth() on Mac.

Batching SkPaint::getTextWidth() http://crrev.com/c/1150010
has no benefits on Mac because Mac uses getTextPath() instead
of getTextWidth() due to
https://bugs.chromium.org/p/skia/issues/detail?id=5328

The cost to prepare batching is usually much lower than the
benefit of batching, the total speed is more than 10x faster,
but since Mac does not get the benefit at all, the cost of
the preparation turned out to be not ignorable.

http://crrev.com/c/1150010:
https://pinpoint-dot-chromeperf.appspot.com/job/14d1dc0fa40000
This CL:
https://pinpoint-dot-chromeperf.appspot.com/job/11a873fda40000

Bug:  868148 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ifbb0f6576cd58f36cd17463a550a15924f5b2209
Reviewed-on: https://chromium-review.googlesource.com/1153007
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578711}
[modify] https://crrev.com/5a643a1efdc29d270b3be8f46adc973514e3d60a/third_party/blink/renderer/platform/fonts/shaping/shape_result.cc

Cc: maxmorin@chromium.org
 Issue 868356  has been merged into this issue.
Status: Fixed (was: Started)
Components: Blink>Fonts
Cc: sky@google.com
 Issue 868507  has been merged into this issue.
 Issue 868518  has been merged into this issue.

Sign in to add a comment