Issue 863256 tracks the refactoring of the XR instrumentation tests. Once that is complete, the browser test equivalents should be refactored to match.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03aebcbf8620fb93b4bab5d9aaa8edbc894809c2 commit 03aebcbf8620fb93b4bab5d9aaa8edbc894809c2 Author: bsheedy <bsheedy@chromium.org> Date: Tue Jul 31 02:12:18 2018 VR Browser Test Refactor Part 1: Match Java Implementation Refactors the VR browser tests to match the newly refactored Java instrumentation tests. Main changes include: * Changing the *TestBase hierarchy to match the *TestFramework Java hierarchy. * Renaming functions that refer to "presentation" to instead refer to "session" * Add versions of functions that automatically use the return value of GetFirstTabWebContents instead of taking a WebContents reference. Follow-up CL(s) will do additional cleanup and update the documentation. Bug: 868143 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifa75c68eafddb9afe1d5f5dee955bd8689c55db7 Reviewed-on: https://chromium-review.googlesource.com/1155718 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#579282} [delete] https://crrev.com/5fac54bad08dbd1a5b91fa05a7e1e6faa0767554/chrome/browser/vr/test/vr_browser_test.h [delete] https://crrev.com/5fac54bad08dbd1a5b91fa05a7e1e6faa0767554/chrome/browser/vr/test/vr_xr_browser_test.cc [delete] https://crrev.com/5fac54bad08dbd1a5b91fa05a7e1e6faa0767554/chrome/browser/vr/test/vr_xr_browser_test.h [rename] https://crrev.com/03aebcbf8620fb93b4bab5d9aaa8edbc894809c2/chrome/browser/vr/test/webvr_browser_test.cc [add] https://crrev.com/03aebcbf8620fb93b4bab5d9aaa8edbc894809c2/chrome/browser/vr/test/webvr_browser_test.h [add] https://crrev.com/03aebcbf8620fb93b4bab5d9aaa8edbc894809c2/chrome/browser/vr/test/webxr_browser_test.cc [add] https://crrev.com/03aebcbf8620fb93b4bab5d9aaa8edbc894809c2/chrome/browser/vr/test/webxr_browser_test.h [add] https://crrev.com/03aebcbf8620fb93b4bab5d9aaa8edbc894809c2/chrome/browser/vr/test/webxr_vr_browser_test.cc [add] https://crrev.com/03aebcbf8620fb93b4bab5d9aaa8edbc894809c2/chrome/browser/vr/test/webxr_vr_browser_test.h [modify] https://crrev.com/03aebcbf8620fb93b4bab5d9aaa8edbc894809c2/chrome/browser/vr/test/xr_browser_test.cc [modify] https://crrev.com/03aebcbf8620fb93b4bab5d9aaa8edbc894809c2/chrome/browser/vr/test/xr_browser_test.h [modify] https://crrev.com/03aebcbf8620fb93b4bab5d9aaa8edbc894809c2/chrome/browser/vr/webvr_frame_pose_browser_test.cc [modify] https://crrev.com/03aebcbf8620fb93b4bab5d9aaa8edbc894809c2/chrome/browser/vr/webvr_input_browser_test.cc [modify] https://crrev.com/03aebcbf8620fb93b4bab5d9aaa8edbc894809c2/chrome/browser/vr/webvr_pixel_browser_test.cc [modify] https://crrev.com/03aebcbf8620fb93b4bab5d9aaa8edbc894809c2/chrome/browser/vr/webvr_tab_browser_test.cc [modify] https://crrev.com/03aebcbf8620fb93b4bab5d9aaa8edbc894809c2/chrome/browser/vr/webvr_transition_browser_test.cc [modify] https://crrev.com/03aebcbf8620fb93b4bab5d9aaa8edbc894809c2/chrome/test/BUILD.gn [modify] https://crrev.com/03aebcbf8620fb93b4bab5d9aaa8edbc894809c2/testing/buildbot/chromium.gpu.fyi.json [modify] https://crrev.com/03aebcbf8620fb93b4bab5d9aaa8edbc894809c2/testing/buildbot/chromium.gpu.json [modify] https://crrev.com/03aebcbf8620fb93b4bab5d9aaa8edbc894809c2/testing/buildbot/test_suites.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/800f506a0bce3313667add16584f77756ea0a2e6 commit 800f506a0bce3313667add16584f77756ea0a2e6 Author: bsheedy <bsheedy@chromium.org> Date: Tue Aug 07 00:47:54 2018 VR Browser Test Refactor Part 2: Additional Cleanup Makes the following changes to the VR browser tests to bring them more in line with the Java implementation: * Renames "webvr_*browser_test.cc" to "webxr_vr_*browser_test.cc" * Adds some missing functions such as "PollJavaScriptBooleanOrFail" * Adds failure messages to all asserts * Standardizes function ordering * Spelling/punctuation fixes * Updates the Markdown documentation * Renames the "vr_browser_tests" test suite to "xr_browser_tests" Bug: 868143 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4ec82eaed3101667cc7574fd0df81aa5d1ce155b Reviewed-on: https://chromium-review.googlesource.com/1157697 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#581072} [delete] https://crrev.com/542cab3c0d82a89a71c4f3b22e7ebe4762e7f8cb/chrome/browser/vr/test/vr_browser_tests.md [modify] https://crrev.com/800f506a0bce3313667add16584f77756ea0a2e6/chrome/browser/vr/test/webvr_browser_test.cc [modify] https://crrev.com/800f506a0bce3313667add16584f77756ea0a2e6/chrome/browser/vr/test/webxr_browser_test.cc [modify] https://crrev.com/800f506a0bce3313667add16584f77756ea0a2e6/chrome/browser/vr/test/webxr_browser_test.h [modify] https://crrev.com/800f506a0bce3313667add16584f77756ea0a2e6/chrome/browser/vr/test/webxr_vr_browser_test.cc [modify] https://crrev.com/800f506a0bce3313667add16584f77756ea0a2e6/chrome/browser/vr/test/xr_browser_test.cc [modify] https://crrev.com/800f506a0bce3313667add16584f77756ea0a2e6/chrome/browser/vr/test/xr_browser_test.h [add] https://crrev.com/800f506a0bce3313667add16584f77756ea0a2e6/chrome/browser/vr/test/xr_browser_tests.md [rename] https://crrev.com/800f506a0bce3313667add16584f77756ea0a2e6/chrome/browser/vr/webxr_vr_frame_pose_browser_test.cc [rename] https://crrev.com/800f506a0bce3313667add16584f77756ea0a2e6/chrome/browser/vr/webxr_vr_input_browser_test.cc [rename] https://crrev.com/800f506a0bce3313667add16584f77756ea0a2e6/chrome/browser/vr/webxr_vr_pixel_browser_test.cc [rename] https://crrev.com/800f506a0bce3313667add16584f77756ea0a2e6/chrome/browser/vr/webxr_vr_tab_browser_test.cc [rename] https://crrev.com/800f506a0bce3313667add16584f77756ea0a2e6/chrome/browser/vr/webxr_vr_transition_browser_test.cc [modify] https://crrev.com/800f506a0bce3313667add16584f77756ea0a2e6/chrome/test/BUILD.gn [modify] https://crrev.com/800f506a0bce3313667add16584f77756ea0a2e6/testing/buildbot/chromium.gpu.fyi.json [modify] https://crrev.com/800f506a0bce3313667add16584f77756ea0a2e6/testing/buildbot/chromium.gpu.json [modify] https://crrev.com/800f506a0bce3313667add16584f77756ea0a2e6/testing/buildbot/test_suite_exceptions.pyl [modify] https://crrev.com/800f506a0bce3313667add16584f77756ea0a2e6/testing/buildbot/test_suites.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4fc2984373fcf78ae335f8c5e28847ebb2f05fc6 commit 4fc2984373fcf78ae335f8c5e28847ebb2f05fc6 Author: Maggie Chen <magchen@chromium.org> Date: Tue Aug 07 19:12:48 2018 Add "Win7 FYI Release (AMD)" back to xr_browser_tests exceptions. There are failurs in Win7 FYI Release (AMD) bot after removing it from the test suit exceptions. Now add it back to the list to keep the bot green. Bug: 868143 Change-Id: I5af929eba7db8f57b334ab759e0a194d8e29e5f9 Reviewed-on: https://chromium-review.googlesource.com/1165662 Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#581301} [modify] https://crrev.com/4fc2984373fcf78ae335f8c5e28847ebb2f05fc6/testing/buildbot/chromium.gpu.fyi.json [modify] https://crrev.com/4fc2984373fcf78ae335f8c5e28847ebb2f05fc6/testing/buildbot/test_suite_exceptions.pyl
Comment 1 by bugdroid1@chromium.org
, Jul 31