New issue
Advanced search Search tips

Issue 868142 link

Starred by 1 user
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Aug 1
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Print Preview: Invalid keys not blocked in number inputs

Project Member Reported by rbpotter@chromium.org, Jul 26 
Chrome Version: 69, 70

What steps will reproduce the problem?
(1) Enable new print preview in chrome://flags
(2) Open Print Preview on any page
(3) Type "1.." into "copies"

What is the expected result?
'..' should not show up in copies box, but should instead be blocked.

What happens instead?
'1..' appears and then disappears, leaving a blank box, and no indication of what the error was.

Regressed with https://crrev.com/c/975825.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b76765a32631ae129baacc941839441098907a92

commit b76765a32631ae129baacc941839441098907a92
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Jul 27 17:00:18 2018

Print Preview Componentization: Fix handling of invalid keys and add test

Key handling for number inputs was accidentally deleted in
https://crrev.com/c/975825. Restore the handling and add a test.

Bug:  868142 
Change-Id: I33f24ded29a58154a8987368c2de1001444755c1
Reviewed-on: https://chromium-review.googlesource.com/1150901
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578677}
[modify] https://crrev.com/b76765a32631ae129baacc941839441098907a92/chrome/browser/resources/print_preview/new/number_settings_section.html
[modify] https://crrev.com/b76765a32631ae129baacc941839441098907a92/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[add] https://crrev.com/b76765a32631ae129baacc941839441098907a92/chrome/test/data/webui/print_preview/number_settings_section_test.js

Comment 2 by rbpotter@chromium.org, Aug 1

Labels: -Pri-1 -M-69 M-70 OS-Chrome OS-Linux OS-Mac OS-Windows Pri-2
Status: Fixed (was: Started)
We will not merge this to M69, since, as documented in  https://crbug.com/869368 , the old UI has not handled these keys correctly since M62.
►

Sign in to add a comment