New issue
Advanced search Search tips

Issue 868139 link

Starred by 1 user
Status: Fixed
Owner:
taku...@chromium.org
Closed: Jul 31
Cc:
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Media Router UI] Hidden pseudo sinks are still counted in metric

Project Member Reported by taku...@chromium.org, Jul 26 
In [1] we subtracted pseudo sinks from the device count metric reported by the WebUI dialog, but we only subtracted visible pseudo sinks. Hidden pseudo sinks are still being counted.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1137029
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dca06bb47667e86a8631056a92ca0cf50801397f

commit dca06bb47667e86a8631056a92ca0cf50801397f
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Fri Jul 27 22:02:27 2018

[Media Router WebUI] Filter out domain-less pseudo sinks from sink count

We were counting hidden (domain-less) pseudo sinks in the device count
metric, which was inflating the data. This CL subtracts such pseudo
sinks from the count.

Bug:  868139 

Change-Id: Ic389b89390ed28f9ebb25af60be452ff2df47c7c
Reviewed-on: https://chromium-review.googlesource.com/1152350
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578822}
[modify] https://crrev.com/dca06bb47667e86a8631056a92ca0cf50801397f/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

Comment 2 by taku...@chromium.org, Jul 31

Status: Fixed (was: Started)
►

Sign in to add a comment