New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 868115 link

Starred by 1 user
Status: Fixed
Owner:
xingliu@chromium.org
Closed: Aug 7
Cc:
█ nancygao@chromium.org
█ aboss@chromium.org
dtrainor@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Download location: Histogram polish.

Project Member Reported by xingliu@chromium.org, Jul 26 
Currently we have 3 histograms for download location change feature.
"MobileDownload.Location.Dialog.Result",
"MobileDownload.Location.Dialog.Type",
"MobileDownload.Location.Setting.DirectoryType",

These are recorded when users interact with UI, we should have a metric to record the directory type when download completes.

To analyze the percentage of users uses SD card location, use unique users query on this new metric.

Also "MobileDownload.Location.Setting.DirectoryType" records when users interact with two different kind of UI, instead we can separate them into 2 histograms.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e87b178924d78031a0968c779955357af2772e8a

commit e87b178924d78031a0968c779955357af2772e8a
Author: Xing Liu <xingliu@chromium.org>
Date: Mon Aug 06 19:28:21 2018

Download location: Records directory type when download completed.

This CL adds a histogram to record directory type when download is
completed.

Also splits the previous directory type histogram into two
separate histograms.

Bug:868115

Change-Id: I68efe49c5d954ab4476675bc739d1bc29f2676eb
Reviewed-on: https://chromium-review.googlesource.com/1152173
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580947}
[modify] https://crrev.com/e87b178924d78031a0968c779955357af2772e8a/chrome/android/java/src/org/chromium/chrome/browser/download/DirectoryOption.java
[modify] https://crrev.com/e87b178924d78031a0968c779955357af2772e8a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadController.java
[modify] https://crrev.com/e87b178924d78031a0968c779955357af2772e8a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadLocationDialogBridge.java
[modify] https://crrev.com/e87b178924d78031a0968c779955357af2772e8a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadMetrics.java
[modify] https://crrev.com/e87b178924d78031a0968c779955357af2772e8a/chrome/android/java/src/org/chromium/chrome/browser/preferences/download/DownloadLocationPreferenceAdapter.java
[modify] https://crrev.com/e87b178924d78031a0968c779955357af2772e8a/tools/metrics/histograms/histograms.xml

Comment 2 by xingliu@chromium.org, Aug 7

Status: Fixed (was: Started)
►

Sign in to add a comment