New issue
Advanced search Search tips

Issue 868101 link

Starred by 1 user
Status: Assigned
Owner:
billorr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-XR



Sign in to add a comment

Consider making GamepadDataFetcherManager not own added factories, but add/remove factories by pointer.

Project Member Reported by billorr@chromium.org, Jul 26 
Feedback from code review (https://chromium-review.googlesource.com/c/chromium/src/+/1147742):

Probably out of scope for this CL, but it's difficult to match up the AddFactory/RemoveSourceFactory calls here.

1) Consider having |this| own IsolatedGamepadDataFetcher.
2) Refactor AddFactory/RemoveSourceFactory add and remove strictly by pointer.

Comment 1 by btebbs@chromium.org, Jul 30

Components: Internals>XR

Comment 2 by benhenry@chromium.org, Aug 2

Status: Assigned (was: Available)

Comment 3 by efoo@chromium.org, Aug 7 

Removing Internals>VR component and assigning to Internals>XR

Comment 4 by efoo@chromium.org, Aug 7

Components: -Internals>VR

Comment 5 by clubsin...@gmail.com, Aug 13

Financial Sample.xlsx
81.5 KB Download
►

Sign in to add a comment