New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 868079 link

Starred by 2 users
Status: Verified
Owner:
shik@chromium.org
Closed: Aug 15
Cc:
jcliang@chromium.org
teravest@chromium.org
emaxx@chromium.org
evgreen@chromium.org
█ wuchengli@chromium.org
█ shu...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

snappy-release: no member named 'GetCameraDeviceInfos' in 'cros::V4L2CameraDevice'

Project Member Reported by sjg@chromium.org, Jul 26 
I am seeing this in snappy-release:

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8939945854753457680


https://luci-logdog.appspot.com/v/?s=chromeos/buildbucket/cr-buildbucket.appspot.com/8939945854753457680/+/steps/BuildPackages__afdo_use_/0/stdout


arc-camera-profile-0.0.1-r93: FAILED: platform/arc-camera/hal/usb/generate_camera_profile.camera_characteristics.o 
arc-camera-profile-0.0.1-r93: x86_64-cros-linux-gnu-clang++ -MMD -MF platform/arc-camera/hal/usb/generate_camera_profile.camera_characteristics.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Iplatform/arc-camera/tools/generate_camera_profile.gen/include -Igen/include -I/build/snappy/tmp/portage/media-libs/arc-camera-profile-0.0.1-r93/work/arc-camera-profile-0.0.1/platform2 -I/build/snappy/tmp/portage/media-libs/arc-camera-profile-0.0.1-r93/work/arc-camera-profile-0.0.1/platform -I/build/snappy/tmp/portage/media-libs/arc-camera-profile-0.0.1-r93/work/arc-camera-profile-0.0.1/platform/arc-camera -I/build/snappy/tmp/portage/media-libs/arc-camera-profile-0.0.1-r93/work/arc-camera-profile-0.0.1/platform/arc-camera/include -I/build/snappy/usr/include -Wall -Wno-psabi -Wunused -Wno-unused-parameter -ggdb3 -fstack-protector-strong -Wformat=2 -fvisibility=internal -Wa,--noexecstack -Werror --sysroot=/build/snappy -DUSE_RTTI_FOR_TYPE_TAGS -Wno-c++11-extensions -Wno-unused-local-typedefs -DBASE_VER=395517 -pthread -I/build/snappy/usr/include/chromeos -I/build/snappy/usr/include/cros-camera -I/build/snappy/usr/include/base-395517 -I/build/snappy/usr/include/glib-2.0 -I/build/snappy/usr/lib64/glib-2.0/include -I/build/snappy/usr/include/nss -I/build/snappy/usr/include/nspr -I/build/snappy/usr/include/dbus-1.0 -I/build/snappy/usr/lib64/dbus-1.0/include -fPIE -std=gnu++14 -DNDEBUG -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -O2 -pipe -O2 -pipe -O2 -pipe -march=corei7 -g -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables  -c ../../../arc-camera-profile-0.0.1/platform/arc-camera/hal/usb/camera_characteristics.cc -o platform/arc-camera/hal/usb/generate_camera_profile.camera_characteristics.o
arc-camera-profile-0.0.1-r93: ../../../arc-camera-profile-0.0.1/platform/arc-camera/hal/usb/camera_characteristics.cc:19:10: fatal error: 're2/re2.h' file not found
arc-camera-profile-0.0.1-r93: #include <re2/re2.h>
arc-camera-profile-0.0.1-r93:          ^~~~~~~~~~~
arc-camera-profile-0.0.1-r93: 1 error generated.
arc-camera-profile-0.0.1-r93: 
arc-camera-profile-0.0.1-r93: [2/4] CXX platform/arc-camera/hal/usb/generate_camera_profile.v4l2_camera_device.o
arc-camera-profile-0.0.1-r93: FAILED: platform/arc-camera/hal/usb/generate_camera_profile.v4l2_camera_device.o 
arc-camera-profile-0.0.1-r93: x86_64-cros-linux-gnu-clang++ -MMD -MF platform/arc-camera/hal/usb/generate_camera_profile.v4l2_camera_device.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Iplatform/arc-camera/tools/generate_camera_profile.gen/include -Igen/include -I/build/snappy/tmp/portage/media-libs/arc-camera-profile-0.0.1-r93/work/arc-camera-profile-0.0.1/platform2 -I/build/snappy/tmp/portage/media-libs/arc-camera-profile-0.0.1-r93/work/arc-camera-profile-0.0.1/platform -I/build/snappy/tmp/portage/media-libs/arc-camera-profile-0.0.1-r93/work/arc-camera-profile-0.0.1/platform/arc-camera -I/build/snappy/tmp/portage/media-libs/arc-camera-profile-0.0.1-r93/work/arc-camera-profile-0.0.1/platform/arc-camera/include -I/build/snappy/usr/include -Wall -Wno-psabi -Wunused -Wno-unused-parameter -ggdb3 -fstack-protector-strong -Wformat=2 -fvisibility=internal -Wa,--noexecstack -Werror --sysroot=/build/snappy -DUSE_RTTI_FOR_TYPE_TAGS -Wno-c++11-extensions -Wno-unused-local-typedefs -DBASE_VER=395517 -pthread -I/build/snappy/usr/include/chromeos -I/build/snappy/usr/include/cros-camera -I/build/snappy/usr/include/base-395517 -I/build/snappy/usr/include/glib-2.0 -I/build/snappy/usr/lib64/glib-2.0/include -I/build/snappy/usr/include/nss -I/build/snappy/usr/include/nspr -I/build/snappy/usr/include/dbus-1.0 -I/build/snappy/usr/lib64/dbus-1.0/include -fPIE -std=gnu++14 -DNDEBUG -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -O2 -pipe -O2 -pipe -O2 -pipe -march=corei7 -g -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables  -c ../../../arc-camera-profile-0.0.1/platform/arc-camera/hal/usb/v4l2_camera_device.cc -o platform/arc-camera/hal/usb/generate_camera_profile.v4l2_camera_device.o
arc-camera-profile-0.0.1-r93: ../../../arc-camera-profile-0.0.1/platform/arc-camera/hal/usb/v4l2_camera_device.cc:21:10: fatal error: 'camera/camera_metadata.h' file not found
arc-camera-profile-0.0.1-r93: #include <camera/camera_metadata.h>
arc-camera-profile-0.0.1-r93:          ^~~~~~~~~~~~~~~~~~~~~~~~~~
arc-camera-profile-0.0.1-r93: 1 error generated.
arc-camera-profile-0.0.1-r93: 
arc-camera-profile-0.0.1-r93: [3/4] CXX platform/arc-camera/tools/generate_camera_profile.generate_camera_profile.o
arc-camera-profile-0.0.1-r93: FAILED: platform/arc-camera/tools/generate_camera_profile.generate_camera_profile.o 
arc-camera-profile-0.0.1-r93: x86_64-cros-linux-gnu-clang++ -MMD -MF platform/arc-camera/tools/generate_camera_profile.generate_camera_profile.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Iplatform/arc-camera/tools/generate_camera_profile.gen/include -Igen/include -I/build/snappy/tmp/portage/media-libs/arc-camera-profile-0.0.1-r93/work/arc-camera-profile-0.0.1/platform2 -I/build/snappy/tmp/portage/media-libs/arc-camera-profile-0.0.1-r93/work/arc-camera-profile-0.0.1/platform -I/build/snappy/tmp/portage/media-libs/arc-camera-profile-0.0.1-r93/work/arc-camera-profile-0.0.1/platform/arc-camera -I/build/snappy/tmp/portage/media-libs/arc-camera-profile-0.0.1-r93/work/arc-camera-profile-0.0.1/platform/arc-camera/include -I/build/snappy/usr/include -Wall -Wno-psabi -Wunused -Wno-unused-parameter -ggdb3 -fstack-protector-strong -Wformat=2 -fvisibility=internal -Wa,--noexecstack -Werror --sysroot=/build/snappy -DUSE_RTTI_FOR_TYPE_TAGS -Wno-c++11-extensions -Wno-unused-local-typedefs -DBASE_VER=395517 -pthread -I/build/snappy/usr/include/chromeos -I/build/snappy/usr/include/cros-camera -I/build/snappy/usr/include/base-395517 -I/build/snappy/usr/include/glib-2.0 -I/build/snappy/usr/lib64/glib-2.0/include -I/build/snappy/usr/include/nss -I/build/snappy/usr/include/nspr -I/build/snappy/usr/include/dbus-1.0 -I/build/snappy/usr/lib64/dbus-1.0/include -fPIE -std=gnu++14 -DNDEBUG -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -O2 -pipe -O2 -pipe -O2 -pipe -march=corei7 -g -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables  -c ../../../arc-camera-profile-0.0.1/platform/arc-camera/tools/generate_camera_profile.cc -o platform/arc-camera/tools/generate_camera_profile.generate_camera_profile.o
arc-camera-profile-0.0.1-r93: ../../../arc-camera-profile-0.0.1/platform/arc-camera/tools/generate_camera_profile.cc:28:17: error: no member named 'GetCameraDeviceInfos' in 'cros::V4L2CameraDevice'
arc-camera-profile-0.0.1-r93:   return device.GetCameraDeviceInfos();
arc-camera-profile-0.0.1-r93:          ~~~~~~ ^
arc-camera-profile-0.0.1-r93: 1 error generated.


I'm not sure if it is a dependency problem, or something else.

Comment 1 by emaxx@chromium.org, Jul 29

Cc: wuchengli@chromium.org emaxx@chromium.org
Labels: OS-Chrome
Owner: jcliang@chromium.org
Status: Assigned (was: Untriaged)
Hitting the same problem.

Adding some OWNERS of platform2/arc-camera.

jcliang@/wuchengli@: Could you please take a look?

Comment 2 by jcliang@chromium.org, Jul 30

Owner: shik@chromium.org

Comment 3 by jcliang@chromium.org, Jul 30

Cc: jcliang@chromium.org

Comment 4 by jcliang@chromium.org, Jul 30 

We had the same bug on buganizer: https://b.corp.google.com/issues/111911591

Shik is working on it.

Comment 5 by teravest@chromium.org, Jul 30

Cc: evgreen@chromium.org teravest@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/arc-camera/+/87f0ac864472277e60b7f6c9f6ec895761c1e191

commit 87f0ac864472277e60b7f6c9f6ec895761c1e191
Author: Shik Chen <shik@chromium.org>
Date: Tue Jul 31 23:37:29 2018

tools: fix compilation error for generate_camera_profile

Get the number of built-in cameras by enumerating symlinks because the
function |GetCameraDeviceInfos()| is removed in CL:1117974.

This is a temporal workaround fix for snappy, which is the only board
that uses this tool.  We will remove this tool once we migrate it to the
new SKU mapping based approach.

BUG=b:111911591, chromium:868079 
TEST=emerge-snappy arc-camera-profile
TEST=Manually run generate_camera_profile on a snappy in the
     lab, and verify its output.

Change-Id: If68e013bc20bae1044696e88f808fdda06dc795f
Reviewed-on: https://chromium-review.googlesource.com/1156341
Commit-Ready: Shik Chen <shik@chromium.org>
Tested-by: Shik Chen <shik@chromium.org>
Reviewed-by: Heng-ruey Hsu <henryhsu@chromium.org>

[modify] https://crrev.com/87f0ac864472277e60b7f6c9f6ec895761c1e191/tools/generate_camera_profile.cc
[modify] https://crrev.com/87f0ac864472277e60b7f6c9f6ec895761c1e191/tools/generate_camera_profile.gyp

Comment 7 by shik@chromium.org, Aug 15

Status: Verified (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 20

Labels: merge-merged-release-R69-10895.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/arc-camera/+/22180c29d8734672a513be634c76fd53b307ae9d

commit 22180c29d8734672a513be634c76fd53b307ae9d
Author: Shik Chen <shik@chromium.org>
Date: Mon Aug 20 08:45:37 2018

tools: fix compilation error for generate_camera_profile

Get the number of built-in cameras by enumerating symlinks because the
function |GetCameraDeviceInfos()| is removed in CL:1117974.

This is a temporal workaround fix for snappy, which is the only board
that uses this tool.  We will remove this tool once we migrate it to the
new SKU mapping based approach.

BUG=b:111911591, chromium:868079 
TEST=emerge-snappy arc-camera-profile
TEST=Manually run generate_camera_profile on a snappy in the
     lab, and verify its output.

Change-Id: If68e013bc20bae1044696e88f808fdda06dc795f
Previous-Reviewed-on: https://chromium-review.googlesource.com/1156341
(cherry picked from commit 453e6142022e8cb33d5da7c1d17cdac7e6a912b3)
Reviewed-on: https://chromium-review.googlesource.com/1177410
Reviewed-by: Heng-ruey Hsu <henryhsu@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>
Commit-Queue: Shik Chen <shik@chromium.org>
Tested-by: Shik Chen <shik@chromium.org>

[modify] https://crrev.com/22180c29d8734672a513be634c76fd53b307ae9d/tools/generate_camera_profile.cc
[modify] https://crrev.com/22180c29d8734672a513be634c76fd53b307ae9d/tools/generate_camera_profile.gyp
►

Sign in to add a comment