New issue
Advanced search Search tips

Issue 868072 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 30
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug
Proj-VR
Proj-XR



Sign in to add a comment

Crash when openvr tries to initialize but no headset attached.

Project Member Reported by billorr@chromium.org, Jul 26

Issue description

OpenVR's destructor tries to stop the message loop, but the message loop may not have been created, so we call into a null object or stale stack data.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bd173472a9d6f46bd465633318d24ac4d4534de

commit 8bd173472a9d6f46bd465633318d24ac4d4534de
Author: Bill Orr <billorr@chromium.org>
Date: Thu Jul 26 22:05:20 2018

Fix some thread cleanup issues that can cause crashes or DCHECKs.

OpenVR and Oculus devices may be destroyed before the render loop is
created.  If this happens we may crash because we call render_loop_->IsRunning().

Next, if we don't call render_loop_->Stop(), the render_loop_'s bindings will be
destroyed on the main thread rather than the render loop thread.

BUG= 868072 

Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibf12af3c38cfa8ed8edf1aebe431a3606476bba7
Reviewed-on: https://chromium-review.googlesource.com/1151952
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578455}
[modify] https://crrev.com/8bd173472a9d6f46bd465633318d24ac4d4534de/device/vr/oculus/oculus_device.cc
[modify] https://crrev.com/8bd173472a9d6f46bd465633318d24ac4d4534de/device/vr/openvr/openvr_device.cc

Labels: Merge-Request-69
We should merge back to 69, since its a crash.
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 27

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Please merge your change to M69 branch 3497 by 2:00 PM PT Monday, 07/30, so we can pick it up for next week last M69 Dev release. Thank you.

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 30

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5ff00bb12a7527f06fd1d31020a86326ee1ce52

commit d5ff00bb12a7527f06fd1d31020a86326ee1ce52
Author: Bill Orr <billorr@chromium.org>
Date: Mon Jul 30 00:02:39 2018

Fix some thread cleanup issues that can cause crashes or DCHECKs.

OpenVR and Oculus devices may be destroyed before the render loop is
created.  If this happens we may crash because we call render_loop_->IsRunning().

Next, if we don't call render_loop_->Stop(), the render_loop_'s bindings will be
destroyed on the main thread rather than the render loop thread.

BUG= 868072 

Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibf12af3c38cfa8ed8edf1aebe431a3606476bba7
Reviewed-on: https://chromium-review.googlesource.com/1151952
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#578455}(cherry picked from commit 8bd173472a9d6f46bd465633318d24ac4d4534de)
Reviewed-on: https://chromium-review.googlesource.com/1154153
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#196}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/d5ff00bb12a7527f06fd1d31020a86326ee1ce52/device/vr/oculus/oculus_device.cc
[modify] https://crrev.com/d5ff00bb12a7527f06fd1d31020a86326ee1ce52/device/vr/openvr/openvr_device.cc

Status: Fixed (was: Started)
Components: Internals>XR

Sign in to add a comment