New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 868065 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 30
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Reporting: MIME type for uploads is now application/reports+json

Project Member Reported by dcreager@chromium.org, Jul 26

Issue description

It was changed in https://github.com/w3c/reporting/issues/51.  Our Reporting implementation still uses the old MIME type of application/report.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/048472b75955777dd9932f44188028e9a0fabe70

commit 048472b75955777dd9932f44188028e9a0fabe70
Author: Douglas Creager <dcreager@chromium.org>
Date: Fri Jul 27 15:48:04 2018

Reporting: Use application/reports+json MIME type for uploads

We changed the MIME type in https://github.com/w3c/reporting/issues/51
as part of the TAG review of the spec.

Bug:  868065 
Change-Id: I4d8020bb39ef12b0695d5f5b16c56eaf2cf0a50e
Reviewed-on: https://chromium-review.googlesource.com/1152069
Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Douglas Creager <dcreager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578656}
[modify] https://crrev.com/048472b75955777dd9932f44188028e9a0fabe70/net/reporting/reporting_uploader.cc
[modify] https://crrev.com/048472b75955777dd9932f44188028e9a0fabe70/net/reporting/reporting_uploader.h
[modify] https://crrev.com/048472b75955777dd9932f44188028e9a0fabe70/net/reporting/reporting_uploader_unittest.cc

Labels: Merge-Request-69 OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 28

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 29

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42a7b0e8587555997c215fd48c46527bffb907c5

commit 42a7b0e8587555997c215fd48c46527bffb907c5
Author: Douglas Creager <dcreager@chromium.org>
Date: Sun Jul 29 13:49:28 2018

Reporting: Use application/reports+json MIME type for uploads

We changed the MIME type in https://github.com/w3c/reporting/issues/51
as part of the TAG review of the spec.

Bug:  868065 
Change-Id: I4d8020bb39ef12b0695d5f5b16c56eaf2cf0a50e
Reviewed-on: https://chromium-review.googlesource.com/1152069
Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Douglas Creager <dcreager@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#578656}(cherry picked from commit 048472b75955777dd9932f44188028e9a0fabe70)
Reviewed-on: https://chromium-review.googlesource.com/1154507
Cr-Commit-Position: refs/branch-heads/3497@{#189}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/42a7b0e8587555997c215fd48c46527bffb907c5/net/reporting/reporting_uploader.cc
[modify] https://crrev.com/42a7b0e8587555997c215fd48c46527bffb907c5/net/reporting/reporting_uploader.h
[modify] https://crrev.com/42a7b0e8587555997c215fd48c46527bffb907c5/net/reporting/reporting_uploader_unittest.cc

Status: Verified (was: Assigned)

Sign in to add a comment