New issue
Advanced search Search tips

Issue 868032 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Feature

Blocked on:
issue 870856
issue 856799
issue 868057
issue 870875
issue 872423
issue 878573



Sign in to add a comment

Upgrade Mac AMD and NVIDIA GPU bots to 10.13.6

Project Member Reported by kbr@chromium.org, Jul 26

Issue description

In Issue 856799 the following GPU bots were upgraded from 10.12 to 10.13:
- Mac AMD Retina 10.12.6 GPU Pool
- Mac NVIDIA Retina 10.12.6 GPU Pool

Apple just released 10.13.6 and we should update these machines to run it.

In order to do this upgrade responsibly we should test 10.13.6 before rolling it out to the entire fleet. The steps needed are documented here:

https://chromium.googlesource.com/chromium/src/+/HEAD/docs/gpu/gpu_testing_bot_details.md#How-to-test-and-deploy-a-driver-update

and the two "experimental" Mac AMD and NVIDIA bots needed to test the new OS version already exist:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Experimental%20Retina%20Release%20(AMD)
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Experimental%20Retina%20Release%20(NVIDIA)

Would like to ask for some help doing this upgrade in cooperation with the Labs team.

 
Cc: cliffordcheng@chromium.org
Owner: bsheedy@chromium.org
Status: Assigned (was: Untriaged)
Blockedon: 868057
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb0e453ebe69f74436c4520c5caa7571e43de699

commit eb0e453ebe69f74436c4520c5caa7571e43de699
Author: bsheedy <bsheedy@chromium.org>
Date: Wed Aug 01 19:29:49 2018

Switch GPU Mac experimental to 10.13.6

Switches the "Mac FYI Experimental Retina Release (AMD)" and
"Mac FYI Experimental Retina Release (NVIDIA)" builders to run tests on
10.13.6.

Bug:  868032 
Change-Id: Ice3945b56ae57260910970188d81266b6f4b2355
Reviewed-on: https://chromium-review.googlesource.com/1158984
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579900}
[modify] https://crrev.com/eb0e453ebe69f74436c4520c5caa7571e43de699/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/eb0e453ebe69f74436c4520c5caa7571e43de699/testing/buildbot/waterfalls.pyl

Blockedon: 870856
Blockedon: 870875
Blockedon: 872423
Status: Started (was: Assigned)
The flakiness that was seen on these bots after the 10.13.6 upgrade has been suppressed in the dependent issues (mainly  Issue 872423  and Issue 870856).

Can we proceed with this upgrade now? Namely, first change the GPU trigger script (per the instructions in the bug description) to run jobs for the AMD and NVIDIA Retina bots on both 10.13.5 and 10.13.6, and then ask the Labs team to upgrade the bots.

The AMD bots, for example, can be found this way:

$ tools/swarming_client/swarming.py bots -S chromium-swarm.appspot.com -b -d pool Chrome-GPU -d gpu 1002:6821 -d os Mac-10.13.5 > ~/tmp/output.txt

The dimensions for the NVIDIA bots can be found in src/testing/buildbot/waterfalls.pyl.

Thanks.

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0544f3b539dc4c2c88821834ab61e4521e85d72c

commit 0544f3b539dc4c2c88821834ab61e4521e85d72c
Author: bsheedy <bsheedy@chromium.org>
Date: Tue Aug 28 22:15:30 2018

Change Mac Retina bots to 10.13.5/6

Changes all Mac Retina bots that were using 10.13.5 to use either
10.13.5 or 10.13.6 in preparation for upgrading all devices to
10.13.6.

Bug:  868032 
Change-Id: Ib9151b52589826bd4fc71317d01eeeea3afe3e9a
Reviewed-on: https://chromium-review.googlesource.com/1189059
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586885}
[modify] https://crrev.com/0544f3b539dc4c2c88821834ab61e4521e85d72c/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/0544f3b539dc4c2c88821834ab61e4521e85d72c/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/0544f3b539dc4c2c88821834ab61e4521e85d72c/testing/buildbot/chromium.gpu.json
[modify] https://crrev.com/0544f3b539dc4c2c88821834ab61e4521e85d72c/testing/buildbot/chromium.webkit.json
[modify] https://crrev.com/0544f3b539dc4c2c88821834ab61e4521e85d72c/testing/buildbot/waterfalls.pyl

Blockedon: 878573
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d9e1d4e6fa372daf07d3a3ffda1965a9671c5dd

commit 3d9e1d4e6fa372daf07d3a3ffda1965a9671c5dd
Author: bsheedy <bsheedy@chromium.org>
Date: Thu Aug 30 19:34:27 2018

Lock GPU Mac Retina devices to 10.13.6

Switches all the waterfalls using Mac Retina devices on Chrome-GPU to
only trigger tests on devices with 10.13.6 instead of both 10.13.6 and
10.13.5 now that all devices have been upgraded to the newer OS vesion.

Bug:  868032 
Change-Id: I58448310621430fae7cec763acedc190a6c29b17
Reviewed-on: https://chromium-review.googlesource.com/1197329
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587709}
[modify] https://crrev.com/3d9e1d4e6fa372daf07d3a3ffda1965a9671c5dd/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/3d9e1d4e6fa372daf07d3a3ffda1965a9671c5dd/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/3d9e1d4e6fa372daf07d3a3ffda1965a9671c5dd/testing/buildbot/chromium.gpu.json
[modify] https://crrev.com/3d9e1d4e6fa372daf07d3a3ffda1965a9671c5dd/testing/buildbot/chromium.webkit.json
[modify] https://crrev.com/3d9e1d4e6fa372daf07d3a3ffda1965a9671c5dd/testing/buildbot/waterfalls.pyl

Status: Fixed (was: Started)

Sign in to add a comment