Limit width of the password drop-down. |
||||||||
Issue descriptionAccording to the spec (https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZRT3KyGvNYc6/files/MCEGxH4Xyp10GcTPe49gBVxzwMSJbxAVNpw) the username value and the masked password should be limited by width.
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62796f0b8459f366de614acefd1cd5979d298799 commit 62796f0b8459f366de614acefd1cd5979d298799 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Fri Jul 27 10:21:31 2018 Limit sizes of the password and username label in the password dropdown. The spec specifies max width for labels in the password dropdown. Bug: 868020 Change-Id: I112c0866e7f0f0165b82f72bdc55c21a25c6c09f Reviewed-on: https://chromium-review.googlesource.com/1151637 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#578583} [modify] https://crrev.com/62796f0b8459f366de614acefd1cd5979d298799/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
,
Jul 30
I'd like to merge r578583. The UI looks nicer with it for the corner cases.
,
Jul 30
,
Jul 31
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a0f54665e92b6a97c4407eca12c22d375051b6d commit 8a0f54665e92b6a97c4407eca12c22d375051b6d Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Tue Jul 31 12:43:20 2018 Limit sizes of the password and username label in the password dropdown. The spec specifies max width for labels in the password dropdown. TBR=vasilii@chromium.org (cherry picked from commit 62796f0b8459f366de614acefd1cd5979d298799) Bug: 868020 Change-Id: I112c0866e7f0f0165b82f72bdc55c21a25c6c09f Reviewed-on: https://chromium-review.googlesource.com/1151637 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578583} Reviewed-on: https://chromium-review.googlesource.com/1156545 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#266} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/8a0f54665e92b6a97c4407eca12c22d375051b6d/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
,
Jul 31
,
Aug 1
vasilii@ - Could you please provide a sample test file/url and manual repro steps to verify the issue from TE-end. Thanks...!!
,
Aug 1
https://rsolomakhin.github.io/autofill/ "Sign in" there with a long username/password and save the credential. Go back to the site and click on the username or password field.
,
Aug 1
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by vasi...@chromium.org
, Jul 2617.2 KB
17.2 KB View Download