New issue
Advanced search Search tips

Issue 868018 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 821009



Sign in to add a comment

Migrate components/google/core/browser/google_url_tracker.h to NetworkConnectionTracker

Project Member Reported by rmcelrath@chromium.org, Jul 26

Issue description

GoogleURLTracker currently uses net::NetworkChangeNotifier to receive network changes. 

With network service, that will need to be converted to using NetworkConnectionTracker's observer APIs.
 
Labels: OS-Windows
Owner: rmcelrath@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f572f5277f875283deb5b3765684213f8c870c7e

commit f572f5277f875283deb5b3765684213f8c870c7e
Author: Robbie McElrath <rmcelrath@chromium.org>
Date: Fri Aug 17 21:21:42 2018

Decouple NetworkConnectionTracker and NetworkService mojo interface.

GoogleURLTracker needs to be migrated from NetworkChangeNotifier to
NetworkConnectionTracker to unblock enabling the network service.
NetworkConnectionTracker currently needs a
network::mojom::NetworkService* in order to to be constructed, but
GoogleURLTracker is used in ios, which doesn't have a NetworkService
instance to give it. NetworkConnectionTracker only actually uses the
NetworkChangeManager interface, so this change makes it depend only on
that, not on the entire NetworkService.

Bug:  868018 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ia2d422686eaf2473c25698f6aa3e6bd66dd04ad4
Reviewed-on: https://chromium-review.googlesource.com/1177186
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584194}
[modify] https://crrev.com/f572f5277f875283deb5b3765684213f8c870c7e/chrome/browser/media/router/discovery/discovery_network_monitor_metric_observer.cc
[modify] https://crrev.com/f572f5277f875283deb5b3765684213f8c870c7e/chrome/browser/printing/cloud_print/privet_traffic_detector.cc
[modify] https://crrev.com/f572f5277f875283deb5b3765684213f8c870c7e/chrome/browser/printing/cloud_print/privet_traffic_detector.h
[modify] https://crrev.com/f572f5277f875283deb5b3765684213f8c870c7e/components/download/internal/background_service/scheduler/device_status_listener_unittest.cc
[modify] https://crrev.com/f572f5277f875283deb5b3765684213f8c870c7e/content/browser/network_service_instance.cc
[modify] https://crrev.com/f572f5277f875283deb5b3765684213f8c870c7e/services/network/public/cpp/network_connection_tracker.cc
[modify] https://crrev.com/f572f5277f875283deb5b3765684213f8c870c7e/services/network/public/cpp/network_connection_tracker.h
[modify] https://crrev.com/f572f5277f875283deb5b3765684213f8c870c7e/services/network/public/cpp/network_connection_tracker_unittest.cc

Cc: cduvall@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d4090014c6a3af87602666e3cd5608842f813d3

commit 0d4090014c6a3af87602666e3cd5608842f813d3
Author: Robbie McElrath <rmcelrath@chromium.org>
Date: Sat Aug 18 02:35:37 2018

Migrate GoogleUrlTracker to NetworkConnectionTracker

This migrates GoogleUrlTracker to use NetworkConnectionTracker instead
of NetworkChangeNotifier so it will work with the network service
enabled.

Bug:  868018 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib8231dc6df2456ae6a0908b49e4626364158ba81
Reviewed-on: https://chromium-review.googlesource.com/1175486
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584289}
[modify] https://crrev.com/0d4090014c6a3af87602666e3cd5608842f813d3/chrome/browser/google/google_url_tracker_factory.cc
[modify] https://crrev.com/0d4090014c6a3af87602666e3cd5608842f813d3/chrome/browser/search/one_google_bar/one_google_bar_loader_impl_unittest.cc
[modify] https://crrev.com/0d4090014c6a3af87602666e3cd5608842f813d3/components/google/core/browser/google_url_tracker.cc
[modify] https://crrev.com/0d4090014c6a3af87602666e3cd5608842f813d3/components/google/core/browser/google_url_tracker.h
[modify] https://crrev.com/0d4090014c6a3af87602666e3cd5608842f813d3/components/google/core/browser/google_url_tracker_unittest.cc
[modify] https://crrev.com/0d4090014c6a3af87602666e3cd5608842f813d3/ios/chrome/browser/google/google_url_tracker_factory.cc
[modify] https://crrev.com/0d4090014c6a3af87602666e3cd5608842f813d3/ios/web/DEPS
[modify] https://crrev.com/0d4090014c6a3af87602666e3cd5608842f813d3/ios/web/browser_state.mm
[modify] https://crrev.com/0d4090014c6a3af87602666e3cd5608842f813d3/ios/web/public/browser_state.h

Status: Fixed (was: Started)

Sign in to add a comment