New issue
Advanced search Search tips

Issue 868017 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 26
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

AdaptiveToolbarViewControllerTest.DetectForceTouch failing on ios-uirefresh-simulator

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jul 26

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of smcgruer@google.com

AdaptiveToolbarViewControllerTest.DetectForceTouch failing on ios-uirefresh-simulator

Example failure:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-uirefresh-simulator/950

Example failure log:

AdaptiveToolbarViewControllerTest.DetectForceTouch:
Did not complete.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9d977bf4beb462f038cc1b55220cc0e3e986eb1

commit c9d977bf4beb462f038cc1b55220cc0e3e986eb1
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Thu Jul 26 18:40:17 2018

Revert "Add unit test for toolbars' force touch gestures"

This reverts commit e630f950e1d7e3ad796004e791e0a6d30ee4adb4.

Reason for revert: AdaptiveToolbarViewControllerTest.DetectForceTouch failing on ios-uirefresh-simulator

Bug:  868017 

Original change's description:
> Add unit test for toolbars' force touch gestures
> 
> This CL adds a unit test for the force touch gesture recognizer added
> to the toolbar buttons, triggering the popup menu.
> 
> Bug:  864430 
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: Icc2524f7e8e58bf20fb4b1381913cb82c57206a8
> Reviewed-on: https://chromium-review.googlesource.com/1150142
> Reviewed-by: Mark Cogan <marq@chromium.org>
> Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578349}

TBR=marq@chromium.org,gambard@chromium.org

Change-Id: I7d4833a56c139ce501c673cd305c19efa456e1e0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  864430 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1151927
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578381}
[modify] https://crrev.com/c9d977bf4beb462f038cc1b55220cc0e3e986eb1/ios/chrome/browser/ui/toolbar/adaptive/BUILD.gn
[delete] https://crrev.com/48d9716bcc72f5899be15244c35297c363ab41e0/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller_unittest.mm
[modify] https://crrev.com/c9d977bf4beb462f038cc1b55220cc0e3e986eb1/ios/chrome/browser/ui/util/BUILD.gn
[delete] https://crrev.com/48d9716bcc72f5899be15244c35297c363ab41e0/ios/chrome/browser/ui/util/force_touch_long_press_gesture_recognizer_unittest.mm
[modify] https://crrev.com/c9d977bf4beb462f038cc1b55220cc0e3e986eb1/ios/chrome/test/BUILD.gn

Status: Fixed (was: Available)

Sign in to add a comment