This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone.

All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff

commit 357abfc8db2042eb1e9b7ab8785cd2514c4f78ff
Author: Robbie McElrath <rmcelrath@chromium.org>
Date: Fri Sep 14 20:43:54 2018

Make TestNetworkConnectionTracker a singleton.

As more classes get migrated from NetworkChangeManager to
NetworkConnectionTracker, more and more tests need a
TestNetworkConnectionTracker instance set up, including many tests that
are pulling in the NetworkConnectionTracker indirectly, so shouldn't
need to set up the test instance themselves. To make sure all tests
have access to the test instance, this CL makes
TestNetworkConnectionTracker a singleton that is setup at the beginning
of each test suite, which ensures only one instance is ever created,
and it's torn down at the right time.

Bug:  868015 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I90ca6ddfa1669f476b03fa7e27230288dfc4101e
Reviewed-on: https://chromium-review.googlesource.com/1214081
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591463}
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/chrome/browser/media/router/discovery/discovery_network_monitor_metric_observer_unittest.cc
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/chrome/browser/media/router/discovery/mdns/cast_media_sink_service_unittest.cc
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/chrome/browser/media/webrtc/webrtc_event_log_manager_unittest.cc
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/chrome/browser/search/one_google_bar/one_google_bar_loader_impl_unittest.cc
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/chrome/browser/signin/chrome_signin_client_unittest.cc
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/chrome/test/base/testing_browser_process.cc
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.cc
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/components/download/internal/background_service/scheduler/device_status_listener_unittest.cc
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/components/download/internal/background_service/test/test_device_status_listener.cc
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/components/download/internal/background_service/test/test_device_status_listener.h
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/components/google/core/browser/google_url_tracker_unittest.cc
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/components/test/BUILD.gn
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/components/test/DEPS
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/components/test/components_test_suite.cc
[add] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/components/test/ios_components_test_initializer.cc
[add] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/components/test/ios_components_test_initializer.h
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/components/variations/service/variations_service_unittest.cc
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/components/web_resource/resource_request_allowed_notifier_unittest.cc
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/components/web_resource/web_resource_service_unittest.cc
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/content/browser/network_service_instance.cc
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/content/public/test/test_content_client_initializer.cc
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/content/public/test/test_content_client_initializer.h
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/services/network/test/test_network_connection_tracker.cc
[modify] https://crrev.com/357abfc8db2042eb1e9b7ab8785cd2514c4f78ff/services/network/test/test_network_connection_tracker.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b63b488890b205259af730bbec7500c3297fedd

commit 6b63b488890b205259af730bbec7500c3297fedd
Author: Robbie McElrath <rmcelrath@chromium.org>
Date: Tue Sep 18 17:38:53 2018

Clean up ChromeSigninClientTest

This is a follow up from a post-merge comment on crrev.com/c/1214081
which moves the SetUp code to the constructor.

Bug:  868015 
Change-Id: Ied0bd568560c49858eeb5261c5d89352f8b1d787
Reviewed-on: https://chromium-review.googlesource.com/1229356
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592099}
[modify] https://crrev.com/6b63b488890b205259af730bbec7500c3297fedd/chrome/browser/signin/chrome_signin_client_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db12d8e7e13fed17677f55e32dc5a26622f4e49c

commit db12d8e7e13fed17677f55e32dc5a26622f4e49c
Author: Robbie McElrath <rmcelrath@chromium.org>
Date: Tue Sep 18 21:20:40 2018

Migrate BackgroundSyncNetworkObserver to NetworkConnectionTracker.

This migrates BackgroundSyncNetworkObserver from NetworkChangeNotifier
to NetworkConnectionTracker, which works with the network service
enabled.

Bug:  868015 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I80ea69e7a5ffc07fc3c79eb1052223f972babd01
Reviewed-on: https://chromium-review.googlesource.com/1214564
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592195}
[modify] https://crrev.com/db12d8e7e13fed17677f55e32dc5a26622f4e49c/ash/BUILD.gn
[modify] https://crrev.com/db12d8e7e13fed17677f55e32dc5a26622f4e49c/ash/test/DEPS
[modify] https://crrev.com/db12d8e7e13fed17677f55e32dc5a26622f4e49c/ash/test/ash_test_environment_content.cc
[modify] https://crrev.com/db12d8e7e13fed17677f55e32dc5a26622f4e49c/ash/test/ash_test_environment_content.h
[modify] https://crrev.com/db12d8e7e13fed17677f55e32dc5a26622f4e49c/chrome/browser/extensions/service_worker_apitest.cc
[modify] https://crrev.com/db12d8e7e13fed17677f55e32dc5a26622f4e49c/content/browser/android/background_sync_network_observer_android.cc
[modify] https://crrev.com/db12d8e7e13fed17677f55e32dc5a26622f4e49c/content/browser/android/background_sync_network_observer_android.h
[modify] https://crrev.com/db12d8e7e13fed17677f55e32dc5a26622f4e49c/content/browser/background_sync/background_sync_browsertest.cc
[modify] https://crrev.com/db12d8e7e13fed17677f55e32dc5a26622f4e49c/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/db12d8e7e13fed17677f55e32dc5a26622f4e49c/content/browser/background_sync/background_sync_network_observer.cc
[modify] https://crrev.com/db12d8e7e13fed17677f55e32dc5a26622f4e49c/content/browser/background_sync/background_sync_network_observer.h
[modify] https://crrev.com/db12d8e7e13fed17677f55e32dc5a26622f4e49c/content/browser/background_sync/background_sync_network_observer_unittest.cc
[modify] https://crrev.com/db12d8e7e13fed17677f55e32dc5a26622f4e49c/content/browser/background_sync/background_sync_service_impl_unittest.cc
[modify] https://crrev.com/db12d8e7e13fed17677f55e32dc5a26622f4e49c/content/browser/network_service_instance.cc
[modify] https://crrev.com/db12d8e7e13fed17677f55e32dc5a26622f4e49c/content/public/test/background_sync_test_util.cc
[modify] https://crrev.com/db12d8e7e13fed17677f55e32dc5a26622f4e49c/content/public/test/background_sync_test_util.h
[modify] https://crrev.com/db12d8e7e13fed17677f55e32dc5a26622f4e49c/content/public/test/test_content_client_initializer.cc
[modify] https://crrev.com/db12d8e7e13fed17677f55e32dc5a26622f4e49c/services/network/test/test_network_connection_tracker.cc