NetworkStatusListenerImpl currently uses net::NetworkChangeNotifier to receive network changes. With network service, that will need to be converted to using NetworkConnectionTracker's observer APIs.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a4e2ac108570b33aa72d86a6a0342b24271418b commit 2a4e2ac108570b33aa72d86a6a0342b24271418b Author: Robbie McElrath <rmcelrath@chromium.org> Date: Thu Aug 16 21:53:31 2018 Migrate download::NetworkStatusListenerImpl to NetworkConnectionTracker This migrates NetworkStatusListenerImpl from using net::NetworkChangeNotifier to content::NetworkConnectionTracker, which works with the network service enabled. Bug: 868011 Change-Id: I98d8644c128174b7b887c76dc40ad2725f052182 Reviewed-on: https://chromium-review.googlesource.com/1161200 Reviewed-by: Min Qin <qinmin@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#583835} [modify] https://crrev.com/2a4e2ac108570b33aa72d86a6a0342b24271418b/chrome/browser/download/download_service_factory.cc [modify] https://crrev.com/2a4e2ac108570b33aa72d86a6a0342b24271418b/components/download/content/factory/download_service_factory.cc [modify] https://crrev.com/2a4e2ac108570b33aa72d86a6a0342b24271418b/components/download/content/factory/download_service_factory.h [modify] https://crrev.com/2a4e2ac108570b33aa72d86a6a0342b24271418b/components/download/internal/background_service/android/network_status_listener_android.cc [modify] https://crrev.com/2a4e2ac108570b33aa72d86a6a0342b24271418b/components/download/internal/background_service/android/network_status_listener_android.h [modify] https://crrev.com/2a4e2ac108570b33aa72d86a6a0342b24271418b/components/download/internal/background_service/scheduler/device_status_listener.cc [modify] https://crrev.com/2a4e2ac108570b33aa72d86a6a0342b24271418b/components/download/internal/background_service/scheduler/device_status_listener.h [modify] https://crrev.com/2a4e2ac108570b33aa72d86a6a0342b24271418b/components/download/internal/background_service/scheduler/device_status_listener_unittest.cc [modify] https://crrev.com/2a4e2ac108570b33aa72d86a6a0342b24271418b/components/download/internal/background_service/scheduler/network_status_listener.cc [modify] https://crrev.com/2a4e2ac108570b33aa72d86a6a0342b24271418b/components/download/internal/background_service/scheduler/network_status_listener.h [modify] https://crrev.com/2a4e2ac108570b33aa72d86a6a0342b24271418b/components/download/internal/background_service/test/BUILD.gn [modify] https://crrev.com/2a4e2ac108570b33aa72d86a6a0342b24271418b/components/download/internal/background_service/test/test_device_status_listener.cc [modify] https://crrev.com/2a4e2ac108570b33aa72d86a6a0342b24271418b/components/download/internal/background_service/test/test_device_status_listener.h [modify] https://crrev.com/2a4e2ac108570b33aa72d86a6a0342b24271418b/content/shell/browser/layout_test/layout_test_background_fetch_delegate.cc
Comment 1 by rmcelrath@chromium.org
, Jul 26