New issue
Advanced search Search tips

Issue 868005 link

Starred by 1 user
Status: Fixed
Owner:
rmcelrath@chromium.org
Closed: Aug 16
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 821009



Sign in to add a comment

Migrate components/data_reduction_proxy/core/browser/* to NetworkConnectionTracker

Project Member Reported by rmcelrath@chromium.org, Jul 26 
DataReductionProxyConfig, DataReductionProxyBypassStats, DataReductionProxyDelegate, and DataReductionProxyConfigServiceClient currently use net::NetworkChangeNotifier to receive network changes.

With network service, that will need to be converted to using NetworkConnectionTracker's observer APIs.

Comment 2 by rmcelrath@chromium.org, Jul 26

Description: Show this description

Comment 3 by rmcelrath@chromium.org, Jul 26

Blocking: 821009
Components: Internals>Services>Network
Owner: rmcelrath@chromium.org
Status: Started

Comment 4 by dxie@google.com, Jul 30

Labels: OS-Windows

Comment 5 by rmcelrath@chromium.org, Aug 1

Description: Show this description
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9eefb859e10fe2b368e06b9e4fc745d427296a9

commit f9eefb859e10fe2b368e06b9e4fc745d427296a9
Author: Robbie McElrath <rmcelrath@chromium.org>
Date: Thu Aug 16 21:08:42 2018

Migrate data_reduction_proxy classes to NetworkConnectionTracker.

This migrates all NetworkChangeNotifier usages in
components/data_reduction_proxy/core/browser to the new
NetworkConnectionTracker, which will work with the network service
enabled.

Bug:  868005 
Change-Id: Ia81ebef073b72f9baa3e97550451ad92c4aac2aa
Reviewed-on: https://chromium-review.googlesource.com/1157345
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583811}
[modify] https://crrev.com/f9eefb859e10fe2b368e06b9e4fc745d427296a9/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
[modify] https://crrev.com/f9eefb859e10fe2b368e06b9e4fc745d427296a9/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc
[modify] https://crrev.com/f9eefb859e10fe2b368e06b9e4fc745d427296a9/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc
[modify] https://crrev.com/f9eefb859e10fe2b368e06b9e4fc745d427296a9/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h
[modify] https://crrev.com/f9eefb859e10fe2b368e06b9e4fc745d427296a9/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
[modify] https://crrev.com/f9eefb859e10fe2b368e06b9e4fc745d427296a9/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/f9eefb859e10fe2b368e06b9e4fc745d427296a9/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
[modify] https://crrev.com/f9eefb859e10fe2b368e06b9e4fc745d427296a9/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc
[modify] https://crrev.com/f9eefb859e10fe2b368e06b9e4fc745d427296a9/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h
[modify] https://crrev.com/f9eefb859e10fe2b368e06b9e4fc745d427296a9/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
[modify] https://crrev.com/f9eefb859e10fe2b368e06b9e4fc745d427296a9/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.cc
[modify] https://crrev.com/f9eefb859e10fe2b368e06b9e4fc745d427296a9/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h
[modify] https://crrev.com/f9eefb859e10fe2b368e06b9e4fc745d427296a9/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/f9eefb859e10fe2b368e06b9e4fc745d427296a9/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc
[modify] https://crrev.com/f9eefb859e10fe2b368e06b9e4fc745d427296a9/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h
[modify] https://crrev.com/f9eefb859e10fe2b368e06b9e4fc745d427296a9/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc
[modify] https://crrev.com/f9eefb859e10fe2b368e06b9e4fc745d427296a9/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc
[modify] https://crrev.com/f9eefb859e10fe2b368e06b9e4fc745d427296a9/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
[modify] https://crrev.com/f9eefb859e10fe2b368e06b9e4fc745d427296a9/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h
[modify] https://crrev.com/f9eefb859e10fe2b368e06b9e4fc745d427296a9/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
[modify] https://crrev.com/f9eefb859e10fe2b368e06b9e4fc745d427296a9/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
[modify] https://crrev.com/f9eefb859e10fe2b368e06b9e4fc745d427296a9/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h

Comment 7 by rmcelrath@chromium.org, Aug 16

Status: Fixed (was: Started)
►

Sign in to add a comment