WidgetTest.FullscreenFrameLayout failing on linux-chromeos-rel |
||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of smcgruer@google.com WidgetTest.FullscreenFrameLayout failing on linux-chromeos-rel Failed on: - https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11175 Example failure: [ RUN ] WidgetTest.FullscreenFrameLayout [30160:31451:0726/104658.261707:1604362297:INFO:service_process_launcher.cc(200)] Launched child process pid=31462, instance=, name=test_ws, user_id=505C0EE9-3013-43C0-82B0-A84F50CF8D84 [31462:31462:0726/104658.291904:1604392542:ERROR:test_gpu_interface_provider.cc(16)] Not implemented reached in void (anonymous namespace)::BindGpuRequest(ui::mojom::GpuRequest) [31462:31462:0726/104658.292027:1604392611:ERROR:test_gpu_interface_provider.cc(22)] Not implemented reached in void (anonymous namespace)::BindDiscardableSharedMemoryManagerRequest(discardable_memory::mojom::DiscardableSharedMemoryManagerRequest) Received signal 11 SEGV_MAPERR 000000000001 #0 0x000000a5e80c base::debug::StackTrace::StackTrace() #1 0x000000a5e381 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7fc9db2a3330 <unknown> #3 0x000000cc2c30 [31462:31462:0726/104658.301168:1604401755:ERROR:window_tree.cc(1346)] Not implemented reached in virtual void ui::ws2::WindowTree::SetHitTestMask(ui::Id, const base::Optional<gfx::Rect> &) views::View::RemoveObserver() #4 0x000000a0fa10 views::DesktopWindowTreeHostMus::~DesktopWindowTreeHostMus() #5 0x000000a0fc05 views::DesktopWindowTreeHostMus::~DesktopWindowTreeHostMus() #6 0x000000cdb8c8 views::DesktopNativeWidgetAura::OnHostClosed() #7 0x000000a1081b views::DesktopWindowTreeHostMus::CloseNow() #8 0x000000cca4c2 views::Widget::CloseNow() #9 0x00000064fd89 views::test::WidgetTest_FullscreenFrameLayout_Test::TestBody() #10 0x0000009a34c2 testing::Test::Run() #11 0x0000009a3f60 testing::TestInfo::Run() #12 0x0000009a4477 testing::TestCase::Run() #13 0x0000009af977 testing::internal::UnitTestImpl::RunAllTests() #14 0x0000009af4ed testing::UnitTest::Run() #15 0x000000a8ae11 base::TestSuite::Run() #16 0x000000a8c4ca base::(anonymous namespace)::LaunchUnitTestsInternal() #17 0x000000a8c37a base::LaunchUnitTests() #18 0x000000466063 views::ViewsTestSuite::RunTests() #19 0x00000044827f main #20 0x7fc9d858ef45 __libc_start_main #21 0x000000437ffa _start
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48d9716bcc72f5899be15244c35297c363ab41e0 commit 48d9716bcc72f5899be15244c35297c363ab41e0 Author: Stephen McGruer <smcgruer@chromium.org> Date: Thu Jul 26 18:32:59 2018 Revert "OopAsh: improve immersive fullscreen for app windows" This reverts commit 4480bf47dbf3708f96dc79b8314a07105b534588. Reason for revert: Strong suspect for causing crashes in WidgetTest.FullscreenFrameLayout on linux-chromeos-rel Bug: 868004 Original change's description: > OopAsh: improve immersive fullscreen for app windows > > Immersive fullscreen for an app window almost works aside from the fact > that the normal frame remains when the app window is fullscreened. This > is a result of not updating the client area inset when the window show > state changes (e.g. from restored to fullscreen). The client area is > updated when the window bounds change, as they would when entering > fullscreen, but the bounds change comes through just before the state > change. Thus, when ClientSideNonClientFrameView checks fullscreen state > during layout, it still finds the widget is restored and calculates the > wrong bounds. The solution is to explicitly kick off a layout when > entering or exiting fullscreen. > > after launching with --enable-features=Mash --ash-dev-shortcuts > > Test: enter and exit fullscreen on an app window with ctrl+shift+F > Bug: 640365 > Change-Id: I499e29427ed072f3428de1f195ede1dc9892e71f > Reviewed-on: https://chromium-review.googlesource.com/1150618 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578353} TBR=sky@chromium.org,estade@chromium.org Change-Id: I2effa307fa2da94610130e6b084b6979fc4c070e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 640365 Reviewed-on: https://chromium-review.googlesource.com/1151908 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#578380} [modify] https://crrev.com/48d9716bcc72f5899be15244c35297c363ab41e0/ui/views/mus/desktop_window_tree_host_mus.cc [modify] https://crrev.com/48d9716bcc72f5899be15244c35297c363ab41e0/ui/views/mus/desktop_window_tree_host_mus.h [modify] https://crrev.com/48d9716bcc72f5899be15244c35297c363ab41e0/ui/views/mus/desktop_window_tree_host_mus_unittest.cc
,
Jul 26
|
||
►
Sign in to add a comment |
||
Comment 1 by smcgruer@chromium.org
, Jul 26Status: Assigned (was: Available)